Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
I just downloaded and installed the latest dev version of the Date module and one of the first dates that I created was a repeating one. I set it to July 20, 2009 and then said to repeat every two weeks until July 31, 2010. The first repeat is set to July 27, which is only 1 week away. Then there is an event every 2 weeks starting from July 27 as the base date. So *all* of the repeating dates are off by 1 week.
Let me know if you can't replicate this and I will provide more data.
Comment | File | Size | Author |
---|---|---|---|
#5 | repeatingdates.patch | 1.01 KB | ldweeks |
Comments
Comment #1
emilymoi CreditAttribution: emilymoi commented+1 .. Just noticed this too.
Comment #2
emilymoi CreditAttribution: emilymoi commentedTook a quick look at this because this was a show stopper for me. It looks like the problem exists in the (huge!) date_repeat_calc function within date_repeat_calc.inc.
This will compare 'Monday' != 'MO'.. so it will always fail. I have changed this to:
And it is working here.. However, I spent a total of 15 minutes looking at this and testing it, so it's probably a very kludgy solution.
Comment #3
emilymoi CreditAttribution: emilymoi commentedComment #4
jtbayly CreditAttribution: jtbayly commentedI'd be happy to test this if somebody could make it into a patch.
Comment #5
ldweeks CreditAttribution: ldweeks commentedHere's a patch...
Comment #6
pauldawg CreditAttribution: pauldawg commented.
Comment #7
mxmilkiib CreditAttribution: mxmilkiib commentedsubscribe
Comment #8
mxmilkiib CreditAttribution: mxmilkiib commentedsubscribe (whoopsy, dupe that can't be deleted - bad wi-fi..)
Comment #9
mxmilkiib CreditAttribution: mxmilkiib commentedah, setting an event to repeat "Every 14 ... Days" works ok.
Comment #10
HnLn CreditAttribution: HnLn commentedsubscribe
Comment #11
gpk CreditAttribution: gpk commentedSubs. Using 6.x-2.4. Have not tried 6.x-2.6 or latest 6.x-dev as yet.
Comment #12
KarenS CreditAttribution: KarenS commentedActually we have the right way to compare the value but are making the wrong comparison. Made a different fix (use $day_names[$day] instead of $day).
Comment #13
gpk CreditAttribution: gpk commentedThanks Karen. And happy new year!