The code does not have many comments, doesn't follow coding standards very closely, and could use a bit of sprucing up.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | taxonomy_defaults-n516240.patch | 10 KB | damienmckenna |
The code does not have many comments, doesn't follow coding standards very closely, and could use a bit of sprucing up.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | taxonomy_defaults-n516240.patch | 10 KB | damienmckenna |
Comments
Comment #1
damienmckennaHere's a patch that cleans up taxonomy_defaults.admin.inc.
Comment #2
mlncn commentedReviewed this patch, not sure if every code change is entirely necessary, applied this patch, it doesn't break anything! Overall +1
ben, agaric
Comment #3
mlncn commentedI take that back.
This patch removes one of the features of taxonomy defaults – the ability to assign terms automatically and invisibly by assigning terms to nodes of a content type that does not otherwise allow that vocabulary.
The
'#disabled' => !$active,, at least, should be removed from the patch, though now I'm a bit more concerned I may not have noticed other lost functionality I also don't happen to be using.Comment #4
bradweikel commentedI'm just going to close this one, for 3 reasons:
1) The patch included not only clean up and and commenting, but sweeping logic changes. Too much scope for one patch.
2) As Ben noted above, the patch breaks some basic features of the module and needs a lot of work.
3) Over the next few weeks I'm going to try to close all open issues on this project and to do a comment & cleanup pass, so this patch will quickly be irrelevant.
I really appreciate the effort, though, Damien. Sorry I've been a bad maintainer lately and didn't leverage your contribution.
Comment #5
damienmckennaNo problem, thanks for getting back to working on it again.