Set wmode to transparent in embed code [#518048]

As I mentioned in http://drupal.org/node/518022, we found an issue with the embed code where wmode is not set to transparent. This is causing dropdown menus on our site to appear behind the slideshowpro swf. We've added a quick wmode=transparent parameter to the embed code, but we'd love to see this get into the module so that we can update when the time comes.

Attached is a small patch to change the embed code (needs to be properly formatted). I also wonder about restructuring to have the embed markup in the theme function. This might provide the option to add different parameters moving forward.

I should also mention that I found this issue http://drupal.org/project/issues/slideshowpro that deals with this and a few other items, but I thought it might be wise to split this out as it's own issue since that was made against d5. If it makes sense to stick with that instead, feel free to give that direction.

Thanks again!

Comment	File	Size	Author
	slideshowpro_add_wmode.patch	1.18 KB	seanbfuller

Comments

Comment #1

seanbfuller commented 13 July 2009 at 18:15

Sorry, that second link should have been http://drupal.org/node/387138

Comment #2

ElvinJones commented 13 January 2010 at 19:51

Hi,

I (Unix patching newbie :) am trying to set wmode = transparent in the embed code. I have copied the patch to /modules/ssp/ folder where the ssp.module file is located.
I edited the slideshowpro_add_smode.patch to the following:

--- ssp.module 2009-07-13 11:55:15.000000000 -0500
+++ ssp.moduleBAK 2009-07-13 11:50:45.000000000 -0500
@@ -221,6 +221,7 @@ function slideshowpro_embed($args) {

- +
+

', $id);
-}
\ No newline at end of file
+}

The following happens when i try to run the patch:

patch -p0 < slideshowpro_add_wmode.patch
patching file ssp.module
Hunk #1 FAILED at 221.
1 out of 1 hunk FAILED -- saving rejects to file ssp.module.rej

I can't seem to find out what the problem might be.

Any help would be appreciated :)