Hi:

I'm testing this, I've watched the videos, but I'm not sure if it's working as it's meant to work, so this note is partly question, partly suggestion.

If I understand correctly, the aim is to be able to replace the automatic crops made by imagecache with custom crops. I think it's meant to be optional: that is, if the user doesn't set a custom crop, then the normal crop process is used. Is this correct?

I'm unclear why there are stepped crop sizes listed in a drop down. What's the purpose of these? Surely the only sizes needed are the imagecache preset sizes? Any other size can be set by changing the shape of the crop box. Any other actions present after the javascript crop action will still be performed, and these would normally include a scaling step.

If I choose my thumnail preset, I get a copy of the automatically generated thumbnail to crop. Is this correct? Shouldn't I be seeing a copy of the original image to base my new crop on?

In the videos, the weight of the action is shown as 1 - more than the weight of the default action. But shouldn't the custom crop be applied before the normal actions? Then if there's no custom crop, the normal process would take place. Perhaps I am misunderstanding "Don't create if region not set'.

Regarding the tickbox for 'Don't crop if cropping region wasn't set'. This seems to require an agreement to a double negative. I know I'm not clear exactly what is meant. Perhaps it should read 'Skip this action when no custom crop is specified by the user'. Or perhaps this is completely redundant: why should the javascript ever apply when no custom crop has been made? Isn't it the job of other actions to deal with normal cropping and scaling?

Regarding the tickbox 'Is the toolbox resizeable or not?'. It's not clear what ticking will achieve. Perhaps the text should read 'Allow the user to drag to resize the crop region'. Again, is there any reason why the user would not always want to be able to drag? Perhaps this too is redundant.

Is there any reason for the 'Click here to create another crop for this image'? By the time the system shows this window, the user has already clicked Crop this image on the original node, isn't it sensible to assume that the user wants to crop the image, and just show them the first crop preset instead of making them click yet another button.

Lastly - this is a brilliant tool, and will be a fantastic step on the way to making Drupal image handling better. Thank you.

Comments

jeff veit’s picture

I maybe should have said: I'm working with cck images.

jayakrishnanj’s picture

Hi smoothstr
could you please provide me the video link? which u have seen. to use this module.

jeff veit’s picture

jayakrishnanj’s picture

Thanks Again.

jeff veit’s picture

I found this excellent description from http://drupal.org/node/325579:

It's a simple mechanism:
- You upload an image with imagefield, image or acidfree
- You define a preset in imagecache and add the javascript crop action.
- After you uploaded a new image, a link will be available underneath the image on the node edit screen which brings up a popup screen
- This popup screen shows the original image and applies the initial crop settings defined in the imagecache preset, ie: Crop 50, 50, center, center
- However, it's now possible to choose a complete other area of the original picture you want to crop. Using an overlay box, you can drag it over the image, alter the size of the result etc
- You can now call this cropped result with /files/imagecache/preset/fileid - just like any other preset which is called with imagecache. What it does now under the hood is looking up if you have overriden the default crop settings for this particular image. The original image is always kept, just as imagecache works, it just generates a new cropped image.

I think this partly answers my questions: I am seeing a bug because I am not seeing the original image but the preset, and it makes not much sense to crop the preset.

jeff veit’s picture

To see the original image the crop tool needs to be first in the chain of filters.

I have the crop according to aspect ratio patch installed too. This could be making a difference.

nils.destoop’s picture

Status: Active » Closed (fixed)