Panels integration fix

Sorry crea,
Love your work!
... but cannot keep up with you at the moment....
I have a lot on my plate outside of Drupal as well as within.... including the launch of two new modules.
I do hope to release some of the recent Revisioning patches, including yours, in the next few days...
Keep up the good work!
Rik

Well you have certainly enticed me to check out Panels+CTools in more detail, crea!
Rik

Hey crea and Rik,

I'm very interested in this panels integration.... a great way to allow more flexible layouts. I'm interested in doing some testing to move the process forward. Will the updated patch in #12 work if applied against the latest 6.x-2.x-dev version (2009-Aug-03)?

Thanks!

--Ben

Hi,

good work.

@crea: Please check if the title of your 'revision_info' pane can be overwritten by user-defined title via panels administration.
I had to change $block->subject into $block->title after upgrading my own content types to Panels 3 to make the pane title editable again.

First:
This patch (along with the revisioning module itself, of course) provides exactly what I was looking for and has made me very happy!!! Thanks crea.

wrt testing (as per #17):
I'm using the patch from #12 applied to revisioning 6.x.2.7.

When I disable the panel (by changing the selection rule - no "disable" link is shown on the main panels page) the revision reverts to appearing as it did before applying the patch.

I can't say anything about access control at the moment because that's something I learning about at the moment and haven't really yet got it all sorted anyway.

Ok I'm sort of hoping this is a simple dimple 2 minute job that you'll be happy to add in to the patch ...

As well as wanting nodes and revisions to look similar when a user views them, which I can now do with the patch, I also want their experience of editing a node versus revision to be similar.

I've only given the node_edit system panel page a cursory look so far, but it seems to be the right tool for making the node edit / creation page more friendly for the user.

The equivalent for revisions would be /node/%node/revisions/%vid/edit.

Is that something you'd be happy to add in, Andrey?

Thanks,
Nick.

Taken from: #718394: suport for panels , by PieWie:
See also: #702344: Revisioning prevents Panels from overriding node/%nid page
---------------------------------------------------------
Hi all

when can we expect support for the module Panels

because when i try to enable the module revisionig
the panels exclude (corresponding nod - Node template)

When I try to once again turn panels receive the following message:

Page manager module is unable to enable node/%node because some other module already has overridden with _revision_view.

this is when you try to enable "Node template"

I used
Revisioning 6.x-3.4
Views 6.x-3.x-dev (2009-sie.-12)
Panels 6.x-3.3

@RdeBoer:
The reason is a 'security behavior' of Panels (resp. CTools' Page Manager which offers the default tasks like "Node template").

Please look at file:
ctools\page_manager\plugins\tasks\node_view.inc

  // Override the node view handler for our purpose.
  $callback = $items['node/%node']['page callback'];
  if ($callback == 'node_page_view' || variable_get('page_manager_override_anyway', FALSE)) { 
...

The page callback for path 'node/%node' must be 'node_page_view' or you must set 'page_manager_override_anyway' variable to TRUE.
Trying the 2nd option (that means creating a new variable entry with value TRUE) should solve your problem.

Good luck.

hi

i installed patch #12
after the operation, I get the following error

Fatal error: Cannot redeclare revisioning_ctools_plugin_directory() (previously declared in /sites/all/modules/revisioning/revisioning.module:1090) in /sites/all/modules/revisioning/revisioning.module on line 1105

@PieWie, #25
That patch is really old and may not apply to the recent versions of Revisioning and Panels.
We may need something along the lines of what M_Z describes in #24.

ok (I had not noticed that it was an old)

i comment this line

//$items['node/%node']['page callback'] = $items['node/%node/view']['page callback'] = '_revision_view';
//$items['node/%node']['page arguments'] = $items['node/%node/view']['page arguments'] = array(1);

and that seems to work for "nod themple" (node/%node)

now looking for line to work with "Node add/edit form" (node/add/%node_type and node/%node/edit)

@PieWie:
(A) Commenting the 2 lines in #27 can lead to unwanted behavior (e.g. if you create a variant (= Panels display) for "node template" with some Selection rule --> then all nodes which fail this selection rule will result in a "wrong" page callback - in your example above this would be 'node_page_view' instead of '_revision_view').

(B) I would suggest the following solution: Put variable_set('page_manager_override_anyway', TRUE); in your *.install file to set this variable, when your module is enabled.

In the code that I posted in #24 your solution (A) ensures the left "OR"-condition in the if-statement, but my suggestion (B) uses the right "OR"-condition.

@M_Z thank for the information
if you could write exactly what and where I write (but step by step)
unfortunately I'm not a programmer

@PieWie:

Option 1:
Create your own custom module (there are many tutorials out there - only 3 files: .info, .module and .install) and place the following code into .install file

/**
 * Implementation of hook_install().
 */
function YOURMODULENAME_install() {
  variable_set('page_manager_override_anyway', TRUE);
}

Upload your custom module and enable it. That's it.

Option 2 (not recommended):
Go to your Drupal database (e.g. by using phpMyAdmin) and add a new row in the variable table with name = page_manager_override_anyway and value = b:1;

@M_Z
thanks
I will try to do this

@M_Z, PieWie
Thanks for your investigations. I don't have the time myself at the moment.
If this works for you without any side-effects, I'll include a similar solution in Revisioning.
Please report back on how you went, confirming Revisioning version number (I assume it's the latest?).
Rik

Here's a tiny little module doing what M_Z recommended. It sets the variable page_manager_override_anyway = TRUE when installed and deletes the same variable when uninstalled. A quick and dirty solution while we wait for a more permanent solution, but it works.

Edit: This fix has been tested with Revisioning 6.x-3.4 together with Panels 6.x-3.3.

Thanks M_Z, Erik. If that's all there is to it, then we should be able to roll something like this out as part of the next release of Revisioning soon.

Patch of #33 checked into repository (HEAD), that is will be present in 6.x-3.6.

#33 now in 6.x-3.6. For those who already have Revisioning installed, you need to disable, uninstall and re-enable it, as the code is run once, upon installation.

Works for me. I needed to uninstall the module which deleted my settings. Would be nice if the code would run during the update process!

You're right crea... I forget about that one. I will better my ways... Good to have someone like you to look over my shoulder, my guardian angel!

Hi everyone! Thanks so much for such a tasty module!

I just downloaded Revisioning 6.x-3.9 installed, and still had the panels security warning after install. I then disabled/re-enabled the module and it worked as expected! No extra coding required.

Do you think this would work?

function revisioning_update_6307() {
  $ret = array();
  // Panels override fix, see http://drupal.org/node/519924#comment-2617370.
  variable_set('page_manager_override_anyway', TRUE);
  module_disable('revisioning');
  module_enable('revisioning');
  return $ret;
}

I am just curious, as I never get to use the update hook! Thanks!

I'm running Revisioning 6.x-3.11 with Panels 6.x-3.7 on a and haven't had any luck getting rid of the "Page manager module is unable to enable node/%node because some other module already has overridden with _revisioning_view" error.

Disabling, uninstalling and re-enabling Revisioning didn't do the trick for me.

Any suggestions? I've been using Revisioning for some time, but am new to Panels. Both modules are on the critical path for the site I'm currently working on. Thanks!

Did you execute update.php ?

I have tried all of the above, disabling and re-enabling, uninstalling and reinstalling, visiting update.php (which didn't have any updates to share), standing on one foot and touching my head while doing all of them again, and am still getting the same error with the latest versions: Revisioning 6.x-3.11 and Panels 6.x-3.7.

Only played around with revisions, mind, as I had installed Panels first.

BBC, you still have to set the override to TRUE.
You can do that with the modules listed before or:
-make a new page
-set input format to php
-type variable_set('page_manager_override_anyway', TRUE);
Save and view the page. After this you can delete this page and the error should disappear when enabling the node template in panels.

Hi all -

I just installed revisioning last week for the site I'm working on...and I got the error, under discussion here, despite the fresh install of 6.x-3.11.

If I'm not mistaken, the variable_set call needs to be in both revisioning_install and revisioning_update_6307, so that new installs get it by default, and folks upgrading their existing install get it too.

However, there's another quick workaround...I used drush to set the variable like so:

drush vset page_manager_override_anyway 1

That did the trick for me...but I wanted to let you know it's not quite fixed yet....

Thanks dsayswhat (#45). Yes the functionality you describe is what is intented and I'll attend to it soon.
Nice tip that drush command.

page_manager_override_anyway is now set when upgrading an old version as well as when installing or (re)installing Revisioning.
Committed to repository.

I confirm this still is an issue with the latest version of revisioning / pages / drupal 6.

You have to run variable_set('page_manager_override_anyway', TRUE); by hand.

After installing the Revisioning module, the variable can be set by opening the update page, and manually select the revisioning module update 6307.

This is fixed on the master branch, so for those who know how to use Git it's available.
It will also be available in the long overdue upgrade, 6.x-3.12, which I will release within a few days.... honest :-)
The master branch also fixes #803112: Revision for translated node (thanks sdelbosc).

After reading all 53 comments it is still not clear if the page_manager_override_anyway stuff will integrate Revisioning into Panels (i.e. let us use Panels to display /node/NID/revisions/VID content) or just let Panels and Revisioning be installed on same site without one complaining about the other (but without further integration).

Would somebody please clarify ?

If a deep integration is not ready, could somebody point me to the issue that discusses it, possibly with newer patches as the one provided by crea at #12 above ?

Thank you in advance

@aviram:

As statet in #12 the path is "node/%node/revisions/%vid/view" and the patch provides a "deep integration" between Revisioning and Panels (i.e. let us use Panels to display /node/NID/revisions/VID content).
But I am not sure, if it works with current Revisioning version, because I tested it with the deprecated 2.x branch of Revisioning module.
Maybe this could help you.

Hey Rik and everyone,

Sorry to re-open this issue, but I'm currently testing the latest 7.x-1.x-dev version and I don't see Panels integration support (as described on this thread) anywhere in the module. Has this Panels integration functionality (allowing panels to override the display of a revision) been ported to the D7 version?

Thanks,
Ben

No there is no Panels integration support yet.
Only a shallow integration was implemented, in that you shouldn't get an error message like this: Page manager module is unable to enable node/%node because some other module already has overridden with....

Subscribe?

sub,.

subscribe.

I realise this is long overdue. It's at the top of my list and I hope to find some time before the end of the year (that's 2011, haha not 2012).
But it's a big item.
And I've never liked Panels...

bump

For others looking for a current solution who come across this issue, check this issue out: #515518: Optional node revision task handler to override default behavior