Right now the "Manage my subscription" are being outputin profile in such way:
t('Manage !my_subscriptions', array('!my_subscriptions' => l(t('my subscriptions'), 'user/'. $account->uid .'/edit/newsletter')))

This brakes the context and don't allow to make a good translation.

Here's a patch to fix this.

CommentFileSizeAuthor
#1 simplenews.520670.patch60.62 KBsutharsan
simplenews-fix-profile-edit-link.patch1.5 KBneochief

Comments

sutharsan’s picture

sutharsan commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Fixed
StatusFileSize
new simplenews.520670.patch60.62 KB

Your patch is more than just fixing the translation problem. I've committed the attached patch to the 2.x branch.

neochief’s picture

neochief commented

Well, 6 months is not a term for great fix :)

Anyways, why haven't you also fixed that bug with "my"? If administrator visits other user's profile it's definitely not "my", but "his/her subscription". Makes sense?

sutharsan’s picture

sutharsan commented

I don't expect admins to get confused by this.

neochief’s picture

neochief commented

Hey, no offense, I just want to help you to make your module better. I understand that it's not very critical and admins possibly will not be confused with this pretty much, but in other hand, the sum of such tiny discrepancies makes the whole quality of the module and a website. Don't you think so? Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.