Cleanup forum description
Bojhan - July 18, 2009 - 13:49
Description
Removed
To rearrange forums and containers, grab a drag-and-drop handle under the Name column and drag the forum or container to a new location in the list. (Grab a handle by clicking and holding the mouse while hovering over a handle icon.) Remember that your changes will not be saved until you click the Save button at the bottom of the page.
Because we shouldn't describe how an interaction works, instead it should be obvious from the interaction itself. Also the please click save is a bit overdone, with also the inline feedback of save.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| Before-cleanup-forums.png | 25.77 KB | Ignored | None | None |
| After-cleanup-forums.png | 17.54 KB | Ignored | None | None |
| cleanup.forum_.description.patch | 1.92 KB | Idle | Failed: Failed to apply patch. | View details | Re-test |
#1
Yes, this seems fine.
As an aside, all this "grab a handle" business was put in at the last possible second of the Drupal 6 string freeze, because this was, then, a new interaction and we weren't certain that people would immediately grasp it, pun intended. But, it seems to have turned out fairly self-explanatory, so there's no need to have the additional text.
#2
Not bad, but we could be more noob-compatible, and even much shorter.
How about:
"All forums on your page. You can put forums into containers to group them."
No need to talk about topics and threads here: this should be on the thread list.
#3
@eigenator: do you mean "All forums on you site" (instead of page)?
#4
Committed to CVS HEAD. Thanks!
#5
@Dries yes. All forums on your site. :)
Though the other version is already comitted, I'd like to give it a shot with the as-short-as-possible one.
#6
Darn, the last one had "page". This one has "site"
#7
And once more because of double hyphens...
It's a real drag that it is not possible to edit or remove attachments on issues in your own comments.
#8
The last submitted patch failed testing.
#9
O.K. this could not work, because the other patch was applied before. New attempt.
This is the description now:
"All forums on your site. You can put forums into containers to group them."
#10
#11
I think you should be able to catch it into one nicely flowing sentence, its to much a "two" thing sentence now. One does not need to explain what this page holds, merely the main concept it is for.
#12
The last submitted patch failed testing.
#13
couple of changes added here, all related to the forum pages admin pages.
changed
This page displays a list of existing forums and containers. Containers (optionally) hold forums, and forums hold forum topics (a forum topic is the initial post to a threaded discussion). To provide structure, both containers and forums may be placed inside other containers and forums.to:
Use containers to group related forums.changed
By grouping related or similar forums, containers help organize forums. For example, a container named "Food" may hold two forums named "Fruit" and "Vegetables", respectively.to:
Containers let you organize forums. For example, a container named "Food" may hold two forums named "Fruit" and "Vegetables".changed
A forum holds related or similar forum topics (a forum topic is the initial post to a threaded discussion). For example, a forum named "Fruit" may contain forum topics titled "Apples" and "Bananas", respectively.to:
A forum holds related forum topics. For example, a forum named "Fruit" may contain forum topics titled "Apples" and "Bananas".changed
These settings allow you to adjust the display of your forum topics. The content types available for use within a forum may be selected by editing the <em>Content types</em> on the forum vocabulary page.to:
Adjust the display of your forum topics. Select the content types that may be used in a forum by editing the <em>Content types</em> on the forum vocabulary page.#14
Screenshots please?
#15
http://skitch.com/yoroy/ngd5i/container-before
http://skitch.com/yoroy/ngdh8/container-after
http://skitch.com/yoroy/ngd57/forum-before
http://skitch.com/yoroy/ngdhj/forum-after
http://skitch.com/yoroy/ngd5x/forums-before
http://skitch.com/yoroy/ngdhg/forums-d7 (= after)
http://skitch.com/yoroy/ngf4m/forumsettings-before
http://skitch.com/yoroy/ngf4f/forumsettings-after
#16
images from yoroy's patch:
Container before
after
Forum before
after
Forum before
after
Settings before
after
#17
Re-rolled it to make it even shorter and by removing unneeded words. Pattern: "For example, a Forum named Fruit" becomes "A forum named Fruit"
Patch and screenshots.
#18
Rerolled, changed "Set content types to use on the Forum vocabulary page"
to "Select content types to use in Forums on the Forum vocabulary page"
Updated the link to that page. And - er - sometimes the controls to choose content types are missing on that page...
#19
uh, and the patch...
#20
The last submitted patch failed testing.
#21
Ok here we go:
Forum list before:
Forum list after:
___
Forum settings before:
Forum settings after:
___
Add container before:
Add container after:
___
Add forum topic before:
Add forum topic after:
#22
status etc.
#23
The last submitted patch failed testing.
#24
No idea how to fix tests.
#25
Bojhan requested that failed test be re-tested.
#26
The last submitted patch failed testing.
#27
Or maybe I do.
#28
woohoo! Now needs review of #21 by humans.
#29
Looking over the code it looks good. Nice change.
#30
Could we avoid silly, nonsensical examples? There is no one on this earth, even Martha Stewart, who is going to name forum categories Fruit and Vegetables and forums Apples and Bananas.
How about describing more "real world" sample forum containers/forums? You know, like these! http://drupal.org/forum
For example, categories of "General" and "Support", and "General" may contain forums such as "News and Announcements" and "General Discussion".
#31
On the other hand, that Fruit/Vegetables and Apple/Bananas example might be very nice in the help text/help page for Taxonomy.
#32
Ok, removed examples in this patch.
#33
Great! Even fewer words. :)
Committed to HEAD.
#34
Automatically closed -- issue fixed for 2 weeks with no activity.