There are two problems with taxonomy:
1) Vocabulary is not required after install, so user can create newsletter without any term selected. If "Use cron to send newsletters" is not selected (and maybe with selected too, I've not tested) and no terms are selected then site will report "Newsletter sent ..." on node save, but it was not sent!
2) If you edit Newsletter vocabulary and save it, you will see error "Invalid vocabulary setting detected...".

Patch fixes both problems. Patch was made from 6.x-1.0-rc6

CommentFileSizeAuthor
#3 simplenews.525174.patch2.36 KBsutharsan
simplenews-taxonomy-fix.patch1.92 KBdmitriy.trt

Comments

dmitriy.trt’s picture

dmitriy.trt commented

Problem 2) also reported in #468290: Editing newsletter's vocabulary unsets associated content types

rsevero’s picture

rsevero commented

I have just been hit by problem number 1).

It is still present on Simplenews 6.x-1.x-dev (2009-out-21).

As far as I can tell, the fix is in the first part of the patch available. It is really simple and self explaining. If problem number 2) is of a more complex nature (I really don't know) I suggest to apply the first part of the patch and fix problem number 1) soon.

To workaround this problem I manually created a new vocabulary and made it required by hand. Finally I deleted the "Newsletter" vocabulary created automatically by Simplenews. The work around isn't hard at all but this small issue can really be a show stopper for new Simplenews users as it's hard to first users to figure out what should be done.

sutharsan’s picture

sutharsan commented
Status: Needs review » Fixed
StatusFileSize
new simplenews.525174.patch2.36 KB

Dmitriy.trt thanks for the patch. Making the newsletter term required at install time was omitted (http://drupal.org/node/372430). Further I slightly altered the patch to describe the (new) situation instead of reacting on the old code.

Attached patch is committed to HEAD and 6.x-1.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

craigdurling’s picture

craigdurling commented

For issue 1) I also did the same. Seemed to work fine.