Performance: Remove Hierarchical Select's form cache and don't reconstruct the entire form anymore

#1

Posted by Wim Leers on July 23, 2009 at 1:06am

This will strongly affect hierarchical_select_after_build() and _hierarchical_select_submit().

Login or register to post comments

#2

Posted by Wim Leers on July 27, 2009 at 1:25pm

And it will remove the need to run _hierarchical_select_form_has_hierarchical_select(), which severely affected performance in some situations: #376159: _hierarchical_select_form_has_hierarchical_select() is expensive (and called from hook_form_alter()).

Login or register to post comments

#3

Posted by Wim Leers on July 28, 2009 at 7:05am

Title:

Remove Hierarchical Select's form cache

» Remove Hierarchical Select's form cache and don't reconstruct the entire form anymore

I'm not entirely sure anymore why I chose to reconstruct the entire form before rendering just the necessary HS form item. This is what makes HS slow on some node forms, because the node form itself is slow to reconstruct. Removing the need to reconstruct the entire form can speed things up *tremendously*.

Login or register to post comments

#4

Posted by Wim Leers on July 28, 2009 at 7:06am

Title:

Remove Hierarchical Select's form cache and don't reconstruct the entire form anymore

» Performance: Remove Hierarchical Select's form cache and don't reconstruct the entire form anymore

Login or register to post comments

#5

Posted by Wim Leers on July 29, 2009 at 8:04pm

Login or register to post comments

#6

Posted by Wim Leers on July 29, 2009 at 8:05pm

This is a performance feature.

Login or register to post comments

#7

Posted by Wim Leers on July 29, 2009 at 8:05pm

Status:

active

» postponed

And will not be for HS 3.0 for D6.

Login or register to post comments

#8

Posted by Flying Drupalist on July 29, 2009 at 8:30pm

Hi, does this mean it'll be for D6 4.x or it won't be for D6 at all?

Login or register to post comments

#9

Posted by Wim Leers on July 29, 2009 at 8:35pm

For D6. More like 3.5. 4.0 will involve API changes.

3.1, 3.2: minor bugfix releases. This is just an optimization and will not change anything visibly.

Interested in writing this? Basically it will require either POSTing all required data or passing most or all of it via a GET request (i.e. via the Drupal path). Not sure if that will be sufficient though. We also have to keep the security implications in mind. If you want to do it, I'll outline what exactly you have to do. Should not be too hard.

Login or register to post comments

#10

Posted by digi24 on November 22, 2009 at 2:51pm

subscribe

I made some measurements, and on my site the ajax call takes approx. 0.8 seconds and consumes a similiar ammount of memory like a regular page with views.