When you cancel your subscription you get the message
You will receive a confirmation email shortly containing further instructions on how to complete the unsubscription process.
"Unsubsciption" isn't a word and the sentence doesn't read right. A better senence would be
You will receive a confirmation email shortly containing further instructions on how to cancel your subscription.
At this stage I have to use the stringoverrides module to fix it.
References:
http://dictionary.reference.com/browse/unsubscription
Problem lines in code:
simplenews.subscription.inc
Line 85, Line 164
I've attached an updated simplenews.subscription.inc to make life a bit easier for the developers. Hope this helps!
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | simplenews-unsubscription-is-not-a-word_530242.patch | 10.33 KB | sutharsan |
Comments
Comment #1
nightowl77 commentedThe file didn't upload (I cannot believe that they don't allow .inc or .php files to be uploaded?!?).
Anyway:
Line 86 can change to:
drupal_set_message(t('You will receive a confirmation email shortly containing further instructions on how to cancel your subscription.'));
Line 164:
t('Confirm the cancellation of your subsciption'),
Comment #2
sutharsan commentedComment #3
sutharsan commentednightowl77, can you use the translations/simplenews.pot file and suggest alternatives for the other occurrences of "unsubscription". I need your input as native speaker.
Comment #4
sutharsan commentedNightowl77 I agree with you that we need to replace 'unsubscription', but I need assistance. Not in the English but in the amount of work. I can't do it all on my own, we got to do it together! Your help is much appreciated.
Comment #5
nightowl77 commentedHi Sutharsan
Sorry for only replying now - I've also been swamped with work and didn't check my drupal recent posts in weeks.
I had a look at the POT file - and I can't find anything wrong other than "unsubscription". I know it is a bit of an issue changing the string in the code (because it might break custom translations out there). But since you're not in your final release it should be ok to let people know in the changelog that they must just update their POT files for 2 entires.
The other solution of course is to create a POT file for English which will "translate" the unsubscription word to what I have above - it will work but to me it feels like using a 10 ton hammer to hit a tiny nail.
But it's your module, it's 100% up to you.
Hope this helps
Comment #6
sutharsan commentedThanks for checking. Those two I can handle, but if you can make patches I would appreciate you help to make a patch for all 'unsubscription' string in code and code comments comments.
Do you know you can receive emails of comments on each of your issues?
Comment #7
sutharsan commentedAttached patch is commited. Will be available in the next 6.x-2.x-dev release.