Tomas,

don't want to step on your coding style, but it would make it easier to hack/modify the BG functionality if you could clean up the code a bit - get rid of commented-out code, put in a couple comments, etc. I know you're busy, anything would be great.

THanks

CommentFileSizeAuthor
#4 image-cleanup.diff4.47 KBdrpchris
#3 bg_mod-cleanup.diff18.16 KBdrpchris
#2 bg_mod-cleanup.diff16.92 KBdrpchris

Comments

vacilando’s picture

vacilando commented

Hey druchris1, don't worry about stepping on it, it's based on very old code which I would nowadays format and document differently indeed :-)

If you have the motivation and a bit of time, go ahead and clean the obvious parts for the currently visible dev version. If it looks good and I won't need to add things back I promise to check and commit it still this weekend.

drpchris’s picture

drpchris commented
StatusFileSize
new bg_mod-cleanup.diff16.92 KB

Diff from 3.4 of the brilliant_gallery.module file. I left some of the debugging code in there commented out, and didn't really do any doc-comments, since that would take me a lot longer.

drpchris’s picture

drpchris commented
StatusFileSize
new bg_mod-cleanup.diff18.16 KB

Sorry, the first patch was not against the -dev tip. This is..

drpchris’s picture

drpchris commented
StatusFileSize
new image-cleanup.diff4.47 KB

Diff for cleanup of image.php

drpchris’s picture

drpchris commented
Assigned: Unassigned » drpchris
Status: Active » Needs review