Scoring system

attached patch has been commited

I have two things I would like to do with the scoring system.

1. This is a code thing, and this is what I have started on:
Make sure score always is updated in the result objects in the OOP framework.

2. This is more a new feature:
Beeing able to set max score on each question in a quiz.

Today each question has a max score, but you can't edit it when assigning the question to a quiz. If question A has a max score of 10, and B has a max score of 1 it seems A is ten times as important as B. If you are to change this today you have to change the questions, and doing that you might mess up other quizes who uses the same questions.

To handle this problem I'm planning to add a new column in the database table quiz_node_relationship named max score.

The max score of each question will default to the max score of the question itself, but will be editable from the screen where you assign questions to quizes.

Any feedback on these planned changes are welcome!

This issue is more or less the same: http://drupal.org/node/506160

I will merge them later.

I have attached a patch showing how (1.) from post #2 has been fixed. These changes has been commited to 4.x-dev.

These changes have two implications for question type developers using the OOP framework(QuizQuestion), especially when extending AbstractQuizQuestionResponse:

1. Never use $this->score. Use $this->getScore() instead.

2. You don't need to store score in $this->score(), just return it.

Why these changes?
When you call getScore() you can be sure that score() is called if it haven't been called earlier. And you can be sure that the result of score() will be stored and automatically reused next time you call getScore(). (And the code becomes even prettier)