To make it run correctly, I had to replace Append option (-r) by Create option (-c) on line 53:


/**
* Implentation of hook_provision_backup()
*/
function drush_provision_drupal_provision_backup($url) {
$backup_file = drush_get_option('backup_file');
// Adds the site directory into the backup file
drush_log(dt("Adding sites directory to !backup_file", array('!backup_file' => $backup_file)), 'backup');
// $result = provision_shell_exec("tar -C %s -p -r -f %s .", drush_get_option('sites_path') . "/$url", $backup_file);
$result = provision_shell_exec("tar -C %s -p -c -f %s .", drush_get_option('sites_path') . "/$url", $backup_file);

if (!$result && !drush_get_option('force', false)) {
drush_set_error('PROVISION_BACKUP_FAILED', dt("Could not back up sites directory for drupal"));
}
}

Adiran,
I would like to have some feedback on this.
Is it a bug?
Is there a design matter?

Thanks.

Alexandre

Comments

anarcat’s picture

Status: Active » Needs work

What error are you getting with -r? It indeed looks odd, and -c is probably the right flag to use in this case... Could you make a proper patch?

adrian’s picture

Status: Needs work » Fixed

This should be -c

-r was a left over from the 0.1 release, which added the db dump in a separate step to the existing tarball (which was created first).

this wasn't causing issues for me on any actual installation, but i am patching it any way.

adrian’s picture

that is as soon as i can actually reach cvs.drupal.org

anarcat’s picture

Project: Hostmaster (Aegir) » Provision

This fix wasn't actually committed, i just committed it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 02f9c2e on debian, dev-dns, dev-envobject, dev-koumbit, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, dev-newhooks, dev-nginx, dev-platform_management, dev-ports, dev-purgebackup, dev-restore, dev-services, dev-simplerinstaller, dev-site_rename, dev-ssl, dev_716166_apache_conf, dev_dns, dev_server_verify, prod-koumbit, ssl, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by adrian:
    Set the umask in the settings.php file, so that directories created by...