Project and Case 'Body field' Optional
lelizondob - July 28, 2009 - 16:45
| Project: | Case Tracker |
| Version: | HEAD |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Jump to:
Description
Hi, I tried to disable the Body field just to see that I can't.
I'm attaching a patch to casetracker_basic.module to change this and only show the body if it hasn't been disabled by the user. Is a very simple patch with the following:
if ($type->has_body) {
$form['body_field'] = node_body_field($node, $type->body_label, $type->min_word_count);
}hope this gets commited.. please review
| Attachment | Size |
|---|---|
| casetracker_basic_optional_body.module.patch | 1.31 KB |
#1
This will help make Case Tracker behave more like core. Nicely done.
#2
will this get committed eventually? making the body optional (as it should be) I think is the way to go since the description could be replaced by a cck textarea field
#3
I'm not really in favor of this change. casetracker_basic is supposed to be a 'get started fast' kind of module. It's not something that expects you to do fancy things with cck. ...it doesn't expect you to do fancy things at all. Given how it's designed to be used (turn key basic case tracking) I'd expect that a description of a case *should* be required. Users of the module certainly don't want people to be able to make new cases without giving any details about the case!
For users with more advanced needs case tracker can be used with *any* content type. If you've using got complex needs and have a complex content type (with many cck fields) you really don't need to be using casetracker_basic.
#4
You have a point when you say it *should* be required, to be honest it didn't make any sense when I was configuring this module for an intranet and removed the body for easier theming and found out I couldn't remove it and I was forced to use the body even if I didn't want to, I thought this was a bug although I didn't want to report it as one. Removing the body to be replaced with a cck field it's (I think) a common practice and I don't really think this is a major issue for those users who want to use the module *as it is* since they can just keep the body, but it is a mayor issue for those who want to change that behavior.
I guess I could have used any other content type just to be able to remove the body, I just never thought about that solution when I started my site and now with 1000+ nodes I guess I'm stuck with a patch I'll have to apply manually with every new release of this module.
Can I ask you to reconsider your position? If not, I think a small note in the README/INSTALL is necessary to alert everyone about this before they start configuring the module since the current text doesn't alert you about the limits of using casetracker_basic
although you can use these, you will get stronger flexibility by assigning it to a content type of your own creationThanks.