Closed (fixed)
Project:
Signup
Version:
6.x-1.0-rc4
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
29 Jul 2009 at 01:53 UTC
Updated:
24 Aug 2009 at 18:40 UTC
Jump to comment: Most recent file
After I updated from rc3 to rc4 I begun to get odd errors.
I have a simple setup: Custom content type with a date field which is associated with "Signup".
Logged in as Admin (uid =1),
Open an event page to edit, no problem
As soon as I click "Signups" on the tabs, opening page would have the odd "Access denied" title and of course nothing else (node/%/signups)
I rebuild the permissions, but no changes.
The think I don't understand is, Admin (uid =1) is the only user. :) I created the event, installed and configured Signup and tried to edit with same account. But right now I am not allowed to see the changes.
Help please.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | event_date.png | 12.65 KB | osman |
| #8 | 533970-8.signup_tab_access_fix.patch | 713 bytes | dww |
Comments
Comment #1
osmanSorry, I forgot to add the environment specs:
Drupal: 6.12
Signup 6.x-1.0-rc4
cck 6.x-2.2
date 6.x-2.2
devel 6.x-1.16
Views 6.x-2.5
PHP:5.2.6
Comment #2
dww- Do you have views configured for any of the signup listings?
- The default views changed between rc3 and rc4 -- did you clear your views cache?
Comment #3
weseze commentedGo to http://www.example.com/admin/settings/signup
Click on "Advanced settings"
Go to "How to display the list of signed-up users:"
Click on "Use the signup-provided listing under the ... tab"
That should fix your problem.
But I think there is a bigger issue here. If you have checked the "Use the signup-provided listing on each node" option then the tab shouldn't be displayed in the first place, because it can not be accessed by anyone...
Comment #4
weseze commentedComment #5
dww@wesley_2mpact: Telling the other user to not use views at all for those listings doesn't necessarily "fix" their problem.
Also, the code is smart enough to not create a "signup" tab on a node for anyone who doesn't have access to view any of the subtabs.
Comment #6
weseze commented@dww: I think I misunderstood the problem then... (sorry) I had the same problem as osman and that's how I fixed it. I assumed that views was not used to display the signups. Perhaps this wasn't the case and then my "fix" will indeed not fix the problem.
I'll try and explain what I think is the problem with this setting and the tab showing up or not. Please correct me if I've got it wrong.
I've got the following setting: (/admin/settings/signup > Advanced settings)
How to display the list of signed-up users:
If you select Use the signup-provided listing under the Signups tab then a tab 'Signups' is shown on the node and it links to a page where you have an overview of all the signups. (very good!)
If you select Use the signup-provided listing on each node (which was the default setting for me when upgrading from rc3 to rc4) then a nice list of users who have signed up is shown on the node itself. (also very good!) But now comes the problem I had. And I think this is what osman also experienced.
The tab 'Signups' is also shown when this setting is enabled. The current user (uid=1) has access to view this tab. But the above setting prevents it from working. I've taken a quick look at the code and derived that when the tab is clicked and the setting does not use the option Use the signup-provided listing under the Signups tab then a 'no access' error will be displayed. That is why I think that the tab shouldn't be shown in the first place if the setting hasn't enabled it.
Please do correct me if I'm wrong or if have the settings mixed up or something!
Comment #7
dwwPlease visit admin/build/modules and submit that form. That'll clear your menu cache and rebuild your menu. That should solve the problem. Please confirm if it does. I forgot to add a DB update when I released RC4 to force sites to do this. I'll remember to do so in RC5, and I'll add a note to the RC4 release notes about it.
Comment #8
dwwUgh. I see the bug now. Introduced in RC4 via #529478: Add a hook to alter access for signup node tabs. Sorry about that! The attached patch should solve it. I'll probably ship RC5 quickly to include this fix, although I'd like to resolve #534948: signup_confirm_email breaks signup_status before RC5, too.
Comment #9
dwwCommitted this to HEAD and DRUPAL-6--1. This will be out in RC5 (probably pretty soon).
Comment #10
osmanas wesley_2mpact guessed it right I have the default settings enabled:
http://example.com/admin/settings/signup
Advanced Settings
Location of the signup form: Included on each node
How to display the list of signed-up users: Use the signup-provided listing on each node
How to display the administrative list of signed-up users: Use the signup-provided listing
Here's also another detail which might be triggering this bug.
I enabled Repeat options for Date
I created an event, see the attached screenshot for date details.
Basically it is an event beginning on June 1st and repeating every Monday until August 31st.
Unfortunately Signup thinks this event is in the past and closes the sign up form.
In fact, it is a repeating event and valid until August 31st. It should be still open for sign up.
At this point I am not sure if this issue is an another bug or related with this one. I see this issue is marked as fixed. So please feel free to delete this post.
Thanks and appreciate it.
Comment #11
dww@osman: That has nothing to do with this issue. You're trying something that's known to be broken. See #298122: Integrate Signup with the Date Repeat API.
This issue is "fixed" since I committed the patch from #8 that solves this bug to HEAD and DRUPAL-6--1. The fix will be out in RC5, probably early next week at the latest.
Comment #12
Sborsody commentedI think I hit this bug. How long until RC5 is out?
Comment #13
dwwProbably as soon as #539052: Before clicking edit button on existing signup, only Attendance select box is disabled is done.
Comment #14
dwwp.s. Two possible work-arounds with RC4:
a) Apply the (trivial) patch from comment #8.
b) Configure your signup attendee list to show up as a tab instead of embedded on your nodes (not ideal, but will work until RC5 is out).
Cheers,
-Derek
Comment #15
gooddesignusa commentedsubscribing.
Comment #16
funana commentedConfirmed, works.