Would it be possible to have a different message that appears for IE7 people so they can be (possibly even more gently) prompted to upgrade to IE8? (While still retaining the original IE6 functionality)

Great module by the way. :-)

Comments

jrglasgow’s picture

Status: Active » Postponed

this is a possibility, let me think on the best way for a bit

BigEd’s picture

mm I could do with this as well.

I have taken a look at the module and this should be pretty easy to implement as its based on the conditional statements.

Wouldnt it be just a case of tweaking it to recognise Ie7?

I can take a look on mine if you need but if you are working on this let me know.

marafa’s picture

ping

fureigh’s picture

The simplest way is to change this line in ie6update.js:

if ( $.browser.msie && ( $.browser.version.substring( 0, 1 ) == '5' || $
.browser.version.substring( 0, 1 ) == '6' ) ) {

to this:

if ( $.browser.msie && ( $.browser.version.substring( 0, 1 ) == '5' || $
.browser.version.substring( 0, 1 ) == '6' || $.browser.version.substring( 0, 1 )
 == '7' ) ) {

Adding an admin setting to allow this to be switched on or off would be preferable, which is why I haven't attached a patch.

jmbouvier’s picture

This is my exact problem too - this works well in ie6 but doesn't appear in ie7 when I've cut and pasted #4.

Any ideas?

danlinn’s picture

I might be a little late to the party here, but in order to get it to show in IE7, you also need to modify ie6update.module and change line 55 to [if lte IE 7] instead of [if IE 6]

Party on.

chiappa’s picture

Thanks but in this way it only shows for IE7 not IE6. How can I have it working for both?

lucascaro’s picture

That code should work for ie 5, 6 and 7, are you sure you copied it right?

you could also try the patch in:

http://drupal.org/node/843926

cheers!

iamEAP’s picture

Version: 6.x-1.0 » 6.x-1.4
Status: Postponed » Active

Re-opening this. If anyone still on this thread is interested enough, I think a configurable conditional stylesheet value is the way to go.

One question I have is: how similar are the message bars at the top of IE6 vs. IE7 vs. IE8 stylistically?

Is it worth re-styling them?

iamEAP’s picture

Status: Active » Patch (to be ported)

According to the IE Conditional Comments documentation, you can use a very basic OR logical operator in conditions. So, for maximum flexibility, I've just set up the config to be checkboxes. By default, only IE6 is selected, but you can select any combination of them, producing a conditional string like the following:

<!--[if (IE 6)|(IE 7)]>

As I noted earlier, I'm not sure if the message bar is consistent stylistically across different versions of IE, so it may appear bizarre in versions IE greater than 6.

Committed to 7.x branch: b7a3540. If anyone still following this is active and wants to test it out, by all means!

iamEAP’s picture

Status: Patch (to be ported) » Fixed

Committed the same to 6.x branch: 6a71bc3

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

a.ross’s picture

Component: Code » Documentation
Category: feature » bug
Status: Closed (fixed) » Active

It may be helpful to add this info to the project description. I didn't know I could use this for IE7 (and up) until I ran into this issue.

iamEAP’s picture

Component: Documentation » Code
Category: bug » feature
Status: Active » Closed (fixed)

The info was on the description page, but I tried highlighting it a bit more.

In the future, please consider opening a new issue rather than re-opening an old one. Nevertheless, thanks for the feedback.