Messages are displayed twice

Hi Daniel,
Thanks for reporting this.
Bit puzzled about this one...
Can you say anything about the conditions under which this "sometimes" happens?
Rik

Hmmmmm, first guess:
This is probably problem with hook_nodeapi('update') running twice and Revisioning not checking that. Let me explain.
When one uses stuff like core actions (+Trigger ?) or some modules like Rules or Workflow, hook_nodeapi('update') can run more than once during single request. As I see Revisioning stores data in $node->revision_moderation so that data may be interpreted more than once.
I faced similar problems with Workflow module: when you use same $node object its passed by reference so one needs to clear any $node object modifications that are used to define behavior logics, before you invoke any code that could invoke additional hook_nodeapi('update') runs. See #472966: Avoid execute_transition twice (when using Rules, Actions) for example of similar problem.

In short, do you use actions or Rules/Workflow module ? If you have any action that updates the node (and triggering Workflow state change does that) that is probably the case. Try disabling that action to see if it solves the problem.

This *is* bug with Revisioning. When using hook_nodeapi('update') developer should by default accept the fact it may be run more than once.
Not only double messages are ugly, but also second message doesn't make any sense since it's programmed run without human invervention.

Find this line:

drupal_set_message(t('Your changes are now current as moderation is switched off for this content type.'), 'warning');

and change to:

drupal_set_message(t('Your changes are now current as moderation is switched off for this content type.'), 'warning', FALSE);

I think it should fix the problem.

Good one!
I had forgotten about that repeat-suppression parameter on drupal_set_message(....);

Thanks crea, dboulet. It's in the dev snap shot.

Something on my site is firing 'alter' twice, and I'm seeing similar repeated messages, e.g. "Displaying current, published revision of...". Patch attached adds FALSE as above.

-        drupal_set_message(_revisioning_node_info_msg($node));
+        drupal_set_message(_revisioning_node_info_msg($node), 'status', FALSE);