View produces two throbber loading signs when doing the ajax call.

Since this module adds it's own and only hides the submit button, not the div surrounding submit module, the throbber is still still shown for the view. 

    $(':submit, .submit-button', form).parent().hide();

Fairly certain all submit buttons have wrappers.

Greate module otherwise; could add some more config options for what exposed forms it works on (use the form alter to add a class around the form, etc.), but cool nether less =)

CommentFileSizeAuthor
#7 viewslivefilters-throbber-538298-6.patch1.03 KBAnonymous (not verified)

Comments

v8powerage’s picture

v8powerage commented

I deleted <span class="views-throbbing">&nbsp</span> from:

viewslivefilters.js
line 22

// Add throbber to element's label
    var throb = function(elem) {
      $(elem).after('<span class="views-throbbing">&nbsp</span>');
    };

I think this should be done in official release too ;-).

hefox’s picture

hefox commented

The issue with removing it from viewslivefilter that is that the throbber would be misplaced; ie the views throbber would be on the submit button not the item that was changed (which is probably what it was adding? been a while); image having more than 1 filter.

v8powerage’s picture

v8powerage commented

This module has option to hide throbber: http://drupal.org/project/viewsdisplaytabs

hefox’s picture

hefox commented

That's cool, but er, what is the purpose of posting it? A suggestion to use that method here? The first mentioned method of hiding the wrapper around the submit works to my memory, but it has the assumption that there is a wrapper. Can't imagine there wouldn't be though since the same processes to build the filter forum happen.

v8powerage’s picture

v8powerage commented
Status: Reviewed & tested by the community » Active

well do what you want, I won't give… I made dirty hack and I'm ok with that, it's better than two throbbers ;-)

kriboogh’s picture

kriboogh commented

FYI, this worked for me (viewslivefilter.js):
$(':submit, .submit-button', form).parent().hide();

Cheers

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new viewslivefilters-throbber-538298-6.patch1.03 KB

I created a patch for #6, which worked for me.

robby.smith’s picture

robby.smith commented
Status: Needs review » Reviewed & tested by the community

thanks, this worked =)

eiland’s picture

eiland commented
Status: Active » Needs work

doesn't work for me. The Ajax property is disabled after applying the patch.

sittard’s picture

sittard commented

Patch does not work. Same as #9

eiland’s picture

eiland commented

for what its worth, my throbbers nicely overlap: http://www.groenestroomjagraag.nl/stroometiket/rwe

philpro’s picture

philpro commented

That's what she said.