This patch sets $force_view_url to TRUE when calling date_real_url to create 'next_url' and 'prev_url'. This is required to allow calendar nav to work with Ajax updates -- the embedded URLs they create without this are gibberish. See: #339279: [calandar] AJAX navigation in month view . There's no ill effects when previewing or editing, with or without javascript turned on as far as I can determine.

CommentFileSizeAuthor
#3 date-nav-view-url-preview.patch820 bytesfearlsgroove
date-nav-force-urls.patch901 bytesfearlsgroove

Comments

fearlsgroove’s picture

fearlsgroove commented

This may be a misfire .. I'm not actually sure the best way to deal with this. I'm not sure what the use case for an embedded view that requires these URL's NOT to be forced would be. As I said in the original post, this works fine for a page display (with a calendar) and in preview mode, with or without javascript ...

fearlsgroove’s picture

fearlsgroove commented
Status: Needs review » Needs work

Definitely breaks blocks. Nevermind gotta be another way to fix this ...

fearlsgroove’s picture

fearlsgroove commented
Title: Date Navigation Previous and Next should force view URL » Date Navigation Preview should not force
StatusFileSize
new date-nav-view-url-preview.patch820 bytes

The issue as I see it is that ajax reloads for views all call preview to display the view. I propose to remove the 'preview' condition as a reason to create a querystring embed URL. Right now, calendar navigation/date browsing is broken for any view that uses preview unless the view is a block. This includes anything displayed with view_embed_view, again unless the display being used is a block display.

So here are the different use cases (my brain hurts from mappping this. That's kinda sad ...):
* Block displays, current: Navigation Works, no ajax
* Block displays, with update: Navigation works, w/ ajax also works
* Block displays using view_embed_view: Navigation Works, no ajax
* Block displays using view_embed_view, with update: Navigation works + ajax
* Page display: Navigation Works, no ajax
* Page display with update: Navigation Works, + ajax
* Non block display embedded: Navigation broken - sends to view url if applicable
* Non block display embedded: Navigation works, AJAX only!
* Any display preview while editing: broken - redirect to a page containing only preview, replacing view admin UI
* ANy display preview with update: everything works! With ajax turned on

So as far as I can tell, nothing is broken (worse than it already is) by this, and it enables AJAX calendar loading. But maybe I've forgotton or missed something?

fearlsgroove’s picture

fearlsgroove commented
Title: Date Navigation Preview should not force » Date Navigation preview should not trigger views "embed" URL

Title ...

attilahooper’s picture

attilahooper commented

I think I just came across this, where I'm calling a calendar page from a view. Nav gets busted in that the url http://mywebpage/homepage?=calendar%2F2009-10 just returns the same month.

fearlsgroove’s picture

fearlsgroove commented
Status: Needs work » Needs review

Shoulda set this to needs review a long time ago ...

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)

Unfortunately the D6 version of this module is no longer supported, but we appreciate the time you put into this.