Closed (fixed)
Project:
Project
Version:
6.x-1.x-dev
Component:
Views integration
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
4 Aug 2009 at 13:31 UTC
Updated:
20 Aug 2009 at 01:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
dwwSort of working. ;) The only snag is that it doesn't yet properly JOIN using {prsv}.tid, since that's a pain. For the Nth time, I wish we just had a denormalized copy of tid in {project_release_nodes}. So, let's do that. ;) #540074: Denormalize release API compatibility tid into {project_release_nodes}
This also doesn't yet touch the data from #539282: Denormalize release info a bit and store latest and recommended releases in {project_release_supported_versions}, but that should be easy to add once that patch lands. We can just keep using this issue for that followup task.
Comment #2
dwwThis is a lot closer. Depends on #540074: Denormalize release API compatibility tid into {project_release_nodes} and almost takes full advantage of #539282: Denormalize release info a bit and store latest and recommended releases in {project_release_supported_versions}. However, the custom filter handler is bogus, since it's hard-coding "node.nid" into the query it constructs. I need to check with merlinofchaos on the right/elegant way to accomplish this...
Also, not positive if I want separate filters for latest and recommended, or if those should be merged into a single filter, so you could, for example, expose it and let folks select which one they want to see... Might simplify the views UI a bit to have a single filter with options, instead of completely separate filters.
Comment #3
dwwSince I woke up and Earl seems to be AFK, I did some investigation myself. Seems like the right approach for #2 is the following:
See attached patch. Still not sure about 1 filter or two, but calling this "needs review" for now...
Comment #4
dwwAs expected/feared, once I got Earl to look, he told me #3 isn't relationship-safe. ;) Re-rolling now...
Comment #5
dwwMerged into a single filter with a UI to select which field you want. Still not relationship-safe, but we're almost there.
Comment #6
dwwHuzzah. Finally got something relationship-safe and working.
Comment #7
dwwAfter a bit more testing, committed to HEAD.