Replace hard-coded release download table with a view

Good work on this. One question--I must have missed something, since I didn't know it was possible to have multiple files for a given release. Is this something new or are you using custom code for a site you're building?

$view->is_cacheable = FALSE;

I wonder if we could simply change this to TRUE?

I see these nice screenshots in #7, but cannot get this working at all and only get #1672724: Unknown column 'project_release_nodes.tid. Can someone take a look and share a hint? I tried finding the root cause, but it looks not that easy. Maybe one of you has a quick idea?

I'm still stuck at D5, but I fixed all the open upgrade bugs I've found and posted the D6 patches in the project queue. They are CNR... Hope you find some time to get them committed to D6!?

The issue #1672724: Unknown column 'project_release_nodes.tid is about D6. It's about project nodes (project/foo) where the download table is normally shown, but currently the table visible in your #7 screenshots is not visible at all, but many errors are shown since the mentioned column .tid does not exists in the database table.

This one is not visible:

I tried to find the tid reference in this views, but failed. There are two views marked as "broken", but I cannot find the cases where this issues are discussed.

It's view project_release_download_table that is broken.

There is something really weird in this view. The INNER JOINS are broken.

Defect:

INNER JOIN project_release_supported_versions project_release_supported_versions_project_release_nodes ON project_release_nodes.pid = project_release_supported_versions_project_release_nodes.nid AND (project_release_supported_versions_project_release_nodes.major = 'project_release_nodes.version_major' AND project_release_supported_versions_project_release_nodes.version_api_tid = 'project_release_nodes.version_api_tid') INNER JOIN term_data term_data_project_release_nodes ON project_release_nodes.tid = term_data_project_release_nodes.tid

Here are single quotes added to 'project_release_nodes.version_major' and 'project_release_nodes.version_api_tid' and project_release_nodes.tid need to be project_release_nodes.version_api_tid

Correct:

INNER JOIN project_release_supported_versions project_release_supported_versions_project_release_nodes
	ON project_release_nodes.pid = project_release_supported_versions_project_release_nodes.nid
	AND (project_release_supported_versions_project_release_nodes.major = project_release_nodes.version_major
	AND project_release_supported_versions_project_release_nodes.tid = project_release_nodes.version_api_tid)
INNER JOIN term_data term_data_project_release_nodes
	ON project_release_nodes.version_api_tid = term_data_project_release_nodes.tid

I just executed this manually in mysql and now I get the proper resultset.

Heck... debugging this view is really a heavy task.

@dww: 'raw' => TRUE, is not a documented feature of views joins. I understand that we really need this here. I guess you are running any custom views patch? Can you share a link to this patch, please?

[project_release_handler_relationship_supported_versions.inc]

  /**
   * Called to implement a relationship in a query.
   */
  function query() {
    $this->ensure_my_table();
    $join = new views_join();
    $join->definition = array(
      'table' => $this->definition['base'],
      'field' => 'nid',
      'left_table' => $this->table_alias,
      'left_field' => $this->field,
      'extra' => array(
        array(
          'field' => 'major',
          'value' => $this->table_alias . '.version_major',
          'raw' => TRUE,
        ),
        array(
          'field' => 'tid',
          'value' => $this->table_alias . '.version_api_tid',
          'raw' => TRUE,
        ),
      ),
    );

#1433516: Provide a way to add raw extra join conditions has no patch.

Damn, RAW is fixed in views DEV. Several hours lost with debugging.

@dww: Could you help commit #1672724: Unknown column 'project_release_nodes.tid, please?

This was fixed in 7.x. I suspect it isn't worth changing in 6.x.