Hi everybody!
it took me long hours but I make it work! this patch allows you to send newsletter issue to multiple newsletters! and even better, it's for D6!!!
Now, I created it against the HEAD, I think it is better for apply by the maintainer. I haven't tested it on 6.x-1.0-rc6.
This patch make a change on simplenews.install, it change the type of the field "tid" in the table "simplenews_newsletters". If you apply this patch against a working website, you should change it by hand on the DB.
One more thing, to enable this feature you have to go to admin/settings/simplenews/general and check the "Multiple select" checkbox.
Hope it helps! please any questions let me know.
Thanks!
--
Jose Sanchez
www.deviancefactory.com
| Comment | File | Size | Author |
|---|---|---|---|
| #33 | simplenews_multiple_newsletters-540432-33.patch | 12.62 KB | agnese.stelce |
| #31 | simplenews-multiple_newsletters-540432-27.patch | 11.66 KB | esolano |
| #4 | simplnews_540432.patch | 16.74 KB | pebosi |
| #1 | simplenews_multiple_newsletters_d6.patch | 16.36 KB | ruloweb |
| simplenews_multiple_newsletters_d6.patch | 16.36 KB | ruloweb |
Comments
Comment #1
ruloweb commentedJust made a little change on simplenews.install.
Thanks!
--
Jose Sanchez
www.deviancefactory.com
Comment #2
Jackinloadup commentedI was able to apply the patch and everything looks ok but i havent tested it yet. we will be sending a newsletter out this next week i will report back ^_^
Thanks for your time and effort!!
Comment #3
burn_ru commentedThanks, great works!
I test this and find theme for suggestion: subscribers with 2 or more subscriptions on each selected terms give 2 or more message with different subject and identical text.
Comment #4
pebosi commentedAdded an update function to change tid field automatically on update.php to #1's patch
regards
Comment #5
pebosi commentedi just send a test newsletter issue to multiple newsletters and it's working fine for me.
regards
Comment #6
sutharsan commentedThis construction of IN(%s) with the implode() not allowed
you need to use db_placeholders()
I appreciate the effort done to realize this functionality but I'm not realy glad with the impact it has on Simplenews developement. I'm currently working on changes to the way taxonomy terms integrate in Simpelnews. With those works on its way I'm not enthousiastic of committing this patch since it will make this change more complex.
Comment #7
ruloweb commentedHi!
thanks for your suggestion, I'll change it ASAP.
Im pretty exited about the new taxonomy integration, but I think this little path will solve the problem that some people is having today.
Please if you need some help let me know, I'll be glad to help on simplenews, it's a module that I use a lot.
Thanks!
--
José Sánchez.
www.deviancefactory.com
Comment #8
Annakan commentedHello
Thanks a lot for the wok on simplenews...
I understand your concern about the patch done here it you are working on something related but I want to express my shared concern for this need.
We can have two views on this issue and one seems better than the other but maybe more complicated to implement.
* First you can do as Josegabriel.st did and allow an issue to be send to multiple "newsletter", making a duplicate issue automatically ...
* second we can have better subscriber management allowing us to have a concept of LISTS or contact groups and a default one for each newsletter, and for each issue we could pick the contact group (or audiences) we want to send the newsletter issue to.
The big advantage of the second idea is that is is more clear, more natural and more importantly that it avoids duplication of the contact addresses in the various newsletter subscription.
Thus you can have separate audiences and mix and max what you send to them on a issue by issue basis ...
This would make SimpleNews much more useful than it already is, and turn it in a great "group mail communication tool"
Comment #9
pharoz commentedsubscribed.
Comment #10
Breakerandi commentedsubscribing... when will the patch be implemented in the module?
Comment #11
Anonymous (not verified) commentedSubscribing. I would love to see this in the core of SimpleNews.
Comment #12
yaron24 commentedSubscribing... I'm trying to move out from phplist and to simplenews and this really bugs me
Comment #13
PunchLine commentedSubscribing...
Comment #14
Webgrafic commentedSubscribing...
Comment #15
sol1313 commentedHi,
I implemented this patch on version 6.x-1.0 but I am not getting a multiple select box on the create a newsletter screen. I still get the drop down. Any ideas?
Comment #16
sutharsan commentedTo keep you updated. With simplenews upgrade to D7 well on its way I can confirm (see #6) that taxonomy is removed from simplenews completely, a simplenews category is introduced instead. Although not yet implemented, I have plans to support sending newsletter issues to multiple mailing lists. So I will not use this patch, but josegabriel.st thanks any way for the inspiration.
Keeping the issue open for further response and use cases.
Comment #17
ruloweb commentedHi!
sol1313:
Have you checked the "Multiple select" checkbox in admin/settings/simplenews/general?
Sutharsan:
that sounds pretty awesome!
Thanks!
--
José Sanchez.
Comment #18
brainchild commentedHey José,
can you please upload an updated version of the patch working with 1.1 version of simplenews? Also, what's about adding some SQL GROUP BY into the query selecting subscribers to avoid duplicates when sending emails?
thanks in advance
Comment #19
ruloweb commentedHi brainchild,
I wont make me time to do that the next weeks.
Sorry!
--
José Sánchez.
Comment #20
djoulle commentedHola José,
Can you please tell me which version of simplenews did you used to create this patch ?
I can't find the correct version to patch...
Gratias !
Comment #21
cindyr commentedTrying to figure out if this will work for my client. Do I understand this right? With this patch, you can now send one newsletter to multiple groups. However, it will not weed out duplicated emails, so if a person is subscribed to both groups, they receive two copies of the same email. Is this correct?
Does anyone have any ideas for a quick hack to weed out the duplicates?
Comment #22
Jackinloadup commentedThis is a pretty easy/ugly SQL hack I have used to get around this.
PLEASE MAKE A BACKUP BEFORE ATTEMPTING THE FOLLOWING
This SQL command will create a new table without duplicates:
After running that delete the original table, simplenews_mail_spool, and rename the new table, simplenews_mail_spool2, to the old name.
Comment #23
TAZ01 commentedSubscribing....
Comment #24
cindyr commentedThanks!
Comment #25
Vidioterie commentedThanks! Exactly what I was looking for.
Just one question: what would be the exact change I have to perform on the database on a running site? I can't seem to figure that out from the code in the patch.
Comment #26
Brainwrap commentedHmmm...I tried applying the patch in #4 and got the following error when attempting the GIT command:
Comment #27
Marko B commentedPatching latest 6.1.3 version doesnt work. I get these errors.
patching file simplenews.admin.inc
Hunk #1 succeeded at 764 (offset -8 lines).
Hunk #2 succeeded at 784 (offset -8 lines).
patching file simplenews.install
Hunk #1 FAILED at 70.
Hunk #2 FAILED at 638.
2 out of 2 hunks FAILED -- saving rejects to file simplenews.install.rej
patching file simplenews.module
Hunk #1 succeeded at 375 with fuzz 1 (offset 9 lines).
Hunk #2 succeeded at 389 (offset 9 lines).
Hunk #3 succeeded at 435 (offset 9 lines).
Hunk #4 succeeded at 1406 (offset 7 lines).
Hunk #5 FAILED at 1417.
Hunk #6 succeeded at 1520 (offset 4 lines).
Hunk #7 FAILED at 1547.
Hunk #8 succeeded at 1589 (offset 15 lines).
Hunk #9 FAILED at 1603.
Hunk #10 succeeded at 1629 (offset 17 lines).
Hunk #11 succeeded at 1687 (offset 17 lines).
Hunk #12 succeeded at 1697 (offset 17 lines).
Hunk #13 succeeded at 1790 with fuzz 2 (offset 46 lines).
Hunk #14 succeeded at 2020 (offset 47 lines).
Hunk #15 succeeded at 2214 (offset 60 lines).
Hunk #16 succeeded at 2323 (offset 69 lines).
Hunk #17 succeeded at 2544 (offset 52 lines).
3 out of 17 hunks FAILED -- saving rejects to file simplenews.module.rej
Comment #28
simon georges commentedNo new feature will be added to 6.x-1.x.
Comment #29
jadowd commentedif you have multiple newsletters, and you want to make one that goes to multiple groups, how do you determine which template gets used? I have a special template called "special edition" that goes out to all subscribers of all groups (OR) to any combination of subgroups. Thoughts?
Comment #30
vasanthns commentedHi,
I would like to have the same feature/functionality in Drupal 7. Is there any support available for Drupal 7 versions to send Newsletters to Multiple Taxonomies/Tags at a time (with out needing to Duplicate the Newsletter).
Thanks in advance.
regards,
Vasanth.
Comment #31
esolano commentedHi all,
In case anyone is still trying get this to work on D6, I created a patch for for version 6.x-2.0-alpha5. I think it also works in current dev version 6.x.2.x-dev.
I hope this helps anyone out there.
Regards!
Comment #33
agnese.stelce commentedA bit improved esolano (#31) patch for 6.x-2.0-alpha5 so that duplicates is not sent if email address is subscribed to more than one newsletter. For more info to successfully apply this patch Drupal core should be >= 6.24 because of taxonomy changes and when patch is applied, taxonomy should be re-saved to display multi select form on node add form.
Comment #34
miro_dietikerFirst, features are against latest dev...
Second, we are talking about D8 steps now and finalizing features in D7.
I guess, we won't add features to D6 anymore. There's so much work to maintain all that (ports, upgrade pathes, ...)