Send a newsletter issue to multiple newsletters (D6 patch)
josegabriel.st - August 5, 2009 - 05:33
| Project: | Simplenews |
| Version: | HEAD |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Description
Hi everybody!
it took me long hours but I make it work! this patch allows you to send newsletter issue to multiple newsletters! and even better, it's for D6!!!
Now, I created it against the HEAD, I think it is better for apply by the maintainer. I haven't tested it on 6.x-1.0-rc6.
This patch make a change on simplenews.install, it change the type of the field "tid" in the table "simplenews_newsletters". If you apply this patch against a working website, you should change it by hand on the DB.
One more thing, to enable this feature you have to go to admin/settings/simplenews/general and check the "Multiple select" checkbox.
Hope it helps! please any questions let me know.
Thanks!
--
Jose Sanchez
www.deviancefactory.com
| Attachment | Size |
|---|---|
| simplenews_multiple_newsletters_d6.patch | 16.36 KB |
#1
Just made a little change on simplenews.install.
Thanks!
--
Jose Sanchez
www.deviancefactory.com
#2
I was able to apply the patch and everything looks ok but i havent tested it yet. we will be sending a newsletter out this next week i will report back ^_^
Thanks for your time and effort!!
#3
Thanks, great works!
I test this and find theme for suggestion: subscribers with 2 or more subscriptions on each selected terms give 2 or more message with different subject and identical text.
#4
Added an update function to change tid field automatically on update.php to #1's patch
regards
#5
i just send a test newsletter issue to multiple newsletters and it's working fine for me.
regards
#6
This construction of IN(%s) with the implode() not allowed
WHERE s.activated = %d AND t.tid IN (%s) AND t.status = %d', 1, implode(',', $node_data['tid'])you need to use db_placeholders()
I appreciate the effort done to realize this functionality but I'm not realy glad with the impact it has on Simplenews developement. I'm currently working on changes to the way taxonomy terms integrate in Simpelnews. With those works on its way I'm not enthousiastic of committing this patch since it will make this change more complex.
#7
Hi!
thanks for your suggestion, I'll change it ASAP.
Im pretty exited about the new taxonomy integration, but I think this little path will solve the problem that some people is having today.
Please if you need some help let me know, I'll be glad to help on simplenews, it's a module that I use a lot.
Thanks!
--
José Sánchez.
www.deviancefactory.com
#8
Hello
Thanks a lot for the wok on simplenews...
I understand your concern about the patch done here it you are working on something related but I want to express my shared concern for this need.
We can have two views on this issue and one seems better than the other but maybe more complicated to implement.
* First you can do as Josegabriel.st did and allow an issue to be send to multiple "newsletter", making a duplicate issue automatically ...
* second we can have better subscriber management allowing us to have a concept of LISTS or contact groups and a default one for each newsletter, and for each issue we could pick the contact group (or audiences) we want to send the newsletter issue to.
The big advantage of the second idea is that is is more clear, more natural and more importantly that it avoids duplication of the contact addresses in the various newsletter subscription.
Thus you can have separate audiences and mix and max what you send to them on a issue by issue basis ...
This would make SimpleNews much more useful than it already is, and turn it in a great "group mail communication tool"
#9
subscribed.
#10
subscribing... when will the patch be implemented in the module?
#11
Subscribing. I would love to see this in the core of SimpleNews.
#12
Subscribing... I'm trying to move out from phplist and to simplenews and this really bugs me