I would like to be able to assign legal T&C on a per-Organic Group basis. I really like the way this module works, but looking through the code it seems to assume only one set of conditions per site.

Ideally, this would expand to include different terms depending on role, group, or other categories (see such as http://drupal.org/node/348022 and http://drupal.org/node/282149 for example), but for my purposes allowing one for each group (with the option of not having conditions for some groups) is sufficient.

Unfortunately I'm in a bit of a hurry, so unless I can see an easy way to accomplish the more general case, I may just whip something up to suit my needs, which would probably be a hack/patch to this module to include a group ID in the 'conditions' table, and modify all the relevant logic to take this into account.

Any implementation ideas/suggestions greatly welcome :)

Comments

sethcohn’s picture

sethcohn commented

While that's a good intention, it's really a far cry from what Legal does now (a single site wide T&C). Lots of things about Legal won't make sense without it, including things like version tracking, blocking access to the site without signing, agreeing on registration, etc.

spiderman’s picture

spiderman
he/they
Primary language English
Location Halifax, NS
commented

@sethcohn: thanks for your thoughts. I agree that this is a bit of a departure from what Legal does right now, although it seemed to me similar enough to make sense. In other words, I'd still track the version of conditions per-group, block access to the group, and require agreeing to the conditions upon signing up (during registration or otherwise) for membership in a group.

Nonetheless, perhaps this is still sufficiently different to warrant a separate project?

sethcohn’s picture

sethcohn commented
Status: Active » Closed (works as designed)

Yes, it's certainly a worthwhile module idea, different enough to make it a standalone, and even work with the current Legal (ie a sitewide legal, and then group by group legal conditions as well).

I'd love to see it as a contrib module for OG, and would be glad to help out with that approach.

spiderman’s picture

spiderman
he/they
Primary language English
Location Halifax, NS
commented

Awesome, sounds good. I'll start working on some code, create the project shortly, and be glad for your help putting it together. One implementation question I have is about the relative merits of storing the T&Cs as nodes of a custom type vs. the approach taken by Legal currently, which just uses a custom DB table. Thoughts?

perceptum’s picture

perceptum commented

Awesome! I'm keen to use a module like this as well - and will be keen to help.

I think both the custom DB table solution might be better - otherwise you will have a node per person signing the T&C.

Unless of course the Node is just for display - and there is a custom table for who has accepted it?

Keen to be involved...

Best
Bryan

spiderman’s picture

spiderman
he/they
Primary language English
Location Halifax, NS
commented

@perceptum: Yes, I meant to say that the T&C's for each group could be stored as nodes, and the per-user acceptance of them would be in a custom table. For the moment, I'm proceeding with the existing infrastructure I've inherited from Legal (ie. 2 custom tables), but I'm open to arguments (and of course, code is gold!) either way. My primary motivation for the moment, however, is to have something up and running for a live site this week ;)

spiderman’s picture

spiderman
he/they
Primary language English
Location Halifax, NS
commented

Actually, if we're going to continue the conversation about nodes vs. custom tables, let's do it in the right place, and leave this issue closed. I've created an issue in the OG Legal issue queue here: #541742: consider implementing conditions as nodes.