Translate all custom block titles (not only custom blocks)

I've created this patch for translating the block title when the user has customized a block title. The customized block title will be translatable from the translation interface.

subscribing. I have the same issue.

subscribing. I have the same issue. (II)

Nothing is broken, so setting back to normal.

There is at least one code style issue inside with a missing line break before "else {". Additional I do not understand why

elseif ($i18nmenu) {

doesn't not become

elseif ($i18nmenu && $block->module == 'menu') {

and

elseif ($i18nmenu && $block->module == 'user' && $block->delta == 1) {

what looks more readable to me.

The
elseif ($i18nmenu) {
is replaced with
else {

Then we need to do 2 things:
1) check if we have i18nmenu enabled and supply translated content for menu blocks
2) and finally supply a translated title for the block

A new slightly modified patch is attached.

There is no feedback to the above suggestions and patch has not changed this way + indention code style bugs.

if
elseif ($i18nmenu && $block->module == 'menu') {
and
elseif ($i18nmenu && $block->module == 'user' && $block->delta == 1) {
are used, then the custom block title for these menus wont use any translations if they are available.

That is why the pseudo code is

      if ($block->module == 'block') {
        TRANSLATE_THE_BLOCK
      }
      else {
        if (BLOCK_IS_MENU) {
          TRANSLATE_THE_MENU_TREE
        }

        TRANSLATE_THE_BLOCK_TITLE  
      }

Of course you can change it to the following if it is more readable

      if ($block->module == 'block') {
        TRANSLATE_THE_BLOCK
      }
      else if (BLOCK_IS_MENU) {
        TRANSLATE_THE_MENU_TREE
        TRANSLATE_THE_BLOCK_TITLE  
      }
      else {
        TRANSLATE_THE_BLOCK_TITLE  
      }

Fixed the indentation bugs

The strings wont appear in the translate interface until you view them in a different language. Can you first try viewing your site in a non-default language so that your menu block is visible. Then go to the translate interface to see if your block title is there.

Can you give me an example of what you are doing. I don't know what you mean by "I refreshed the strings again in my default language, and they disappeared."

I can reproduce what you describe, after doing a refresh the translations are gone.

If you don't do a refresh are the blocks translated OK?

The refresh problem looks the same as what is described here: http://drupal.org/node/442428

Hi,

I just came across this after writing a patch of my own for this very issue. I've taken a slightly different approach in that the patch allows all blocks to be set to 'All languages (translatable)' (not just custom) and creates the title i18n strings for all translatable blocks when they are created/saved so no need to switch to required languages or attempt the refresh of doom... i18n strings for content are created for custom blocks only.

Apologies if it's bad form to attach another patch to an existing issue.

Andy

Sorry - that last patch included patch 500662. This one is just my i18n block title patch.

Patch have trailing whitespace.

Subscribe

Subscribe

You seem to have solved a long standing issue!
When can we get this committed?
I don't know how to patch and the modifications are to heavy to be done manually.
Possibly I would appreciate the patched i18nblocks.module and i18nstrings.module fully coocked...

Three test results, possibly for further confirmation:

A - After applying the patch manually to 6.x-1.1, as #28 (#8). Using a block created by the ed classified module (Latest ads...):

- a block string (i.e. block:3:title) is found and can be translated
- the translation does not show in the block heading, where it is expected
- in the translation ui, the translation is retained after strings refresh

B - since the translation did not show in the block heading, after adding the omitted elseif statement:

- two translation strings appear, the original one (block:3:title), and a new one specifically identified with the module (i.e. ed_classified:12:title), the new one can also be translated
- the translation (presumably ed_classified:12:title) appears on site in the block heading, as intended (super)

- after refresh strings, the first string (block:3:title) disappears from searches (and does not return), the second one (ed_classified:12:title) is found while its translation is lost from the translation ui
- the block heading translation is lost

I checked my patching and think it's correct, yet could this be further tested?

C - After uploading i18n 6.x-1.x-dev Last updated: November 7, 2009 - 07:08, using the same block as above, and after clearing cache etc.:

- one block string, module related (ed_classified:12:title), is found and can be translated
- the translation does not show in the block heading, where it is expected
- the refresh checkmark option for blocks is not available anymore, string refresh not done

So, something is not yet quite right, while result B with the original patch #8 did show a translated block heading...

@jose

thanks. Above I'm using the contributed ed classifieds module as an example - please note that its translated block heading shows nicely in test B. To clarify:

C above tests the -dev version: Result: no translation shows for the contrib module heading
B above tests patch #8. Result: --- the translation shows as intended ---
A above tests patch #8 minus the elseif code: no translation shows for the contrib module heading

The removed part of patch #8 appears to be responsible for showing a translated contributed module heading. The current -dev version apparently translates the string, but the translation does not appear in the contrib module heading.

I'm not coder, so I can't make a code suggestion.

---
PS: I've now also tested a core module block, specifically Recent comments: yes, the translated heading shows as intended.

Need to add to C above for -dev version:
- for core module block (recent comments), translation ok for each: default and "override" titles/headings.
- for contrib block (ed_classified), translation no show for the default but *does* show for "override" titles/headings.

How this patch is used? should I put it a zip file and upload to the modules directory and extract and it will work? Thanks for any assistance