Hello, there is a little bug in i18nmenu.module at line 313 :

if (!$node->menu->mlid && !empty($node->translation_source)) {

must be :

if (!$node->menu['mlid'] && !empty($node->translation_source)) {

CommentFileSizeAuthor
#4 i18n-php-warnings_541834.patch3.37 KBhass
#1 i18n-php-warnings.patch2.63 KBeMPee584

Comments

eMPee584’s picture

eMPee584 commented
Version: 6.x-1.1 » 6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new i18n-php-warnings.patch2.63 KB

There are more. Someone has been sleeping again over at that quality assurance department X)

hass’s picture

hass commented

The line l10_client_add_string_to_page() depends on #361147: Support for different text groups and looks like an invalid fix.

hass’s picture

hass commented
Status: Needs review » Needs work

Patch does not apply at all.

hass’s picture

hass commented
Status: Needs work » Fixed
StatusFileSize
new i18n-php-warnings_541834.patch3.37 KB

The patch in #1 seems to have not passed any required QA tests.

Committed the attached patch.

eMPee584’s picture

eMPee584 commented

ok hass that hurt *g
no seriously,

better code in == better more good++

hass’s picture

hass commented

aehm - what? Maybe I understand this in German :-)

eMPee584’s picture

eMPee584 commented

just joking around :p

mehr guter code rein == alle viel glücklicher

;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.