Allow creating and updating Decisions programatically

So again, you seem to be completely ignoring the issue #514562: Allow creating decisions programatically and while I really appreciate you contributing to the project, I would also appreciate if you would actually avoid creating duplicate issues. If the patch in the other issue is improper, please say so *in the other issue* so that the original poster of the issue can also comment and review it. Now I have to update two issues instead of one and it makes my work harder and less desirable, which in turn makes your patch less likely to get into CVS.

So what you need to do now is to post your patch in the issue #514562: Allow creating decisions programatically. But before that, you may want to fix the following issues:

+  // Calculate end date and intialize star date and runtime
+ 	$enddate = _decisions_enddate_calc($decision);

Indentation is wrong there.

+  if (!is_array($node->settings['date']['startdate']['date'])) {
+    $node->settings['date']['startdate']['date'] = _decisions_form_prepare_datetime($node->settings['date']['startdate']['date']);
+	}

Here too.

+	  // Format dates if hook_update processed without form
+	  if (!is_array($node->settings['date']['enddate']['date'])) {
+		  $node->settings['date']['enddate']['date'] = _decisions_form_prepare_datetime($node->settings['date']['enddate']['date']);
+    }
+

Same here.

+/**
+ * Calculate enddate and initialize startdate and runtime
+ */
+function _decisions_enddate_calc($node) {

That *may* be a good idea, but I'm not sure it actually works: the $node->runtime variable is changed in the function but the $node is not passed by reference, then you reuse that variable outside the function:

-    '#collapsed' => ($runtime != DECISIONS_RUNTIME_INFINITY),
+    '#collapsed' => ($node->runtime == DECISIONS_RUNTIME_INFINITY),

That seems wrong to me.

Also, as a rule of thumb, I don't generally refactor code if it's duplicated once. It's at the third instance I refactor. So it would probably be simple to just put the function inline.

I also need a way to test this. Please provide some test script to show me what the current problem is and how to test it is really resolved.

Finally, please make any further updates in #514562: Allow creating decisions programatically. You can reupload your patch there and it's the proper issue to follow up on. I'm closing this as duplicate, as I have already told you about this in #532242: some decision settings are not saved properly. Thank you.