Posted by deekayen on August 7, 2009 at 6:01pm
| Project: | Reroute Email |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
Even in a production environment, there have been times where I have wanted to be BCCed on all outgoing emails, just to prove they were being sent. #543022: How do I know if it's working? on inactive user reminds me of that need and I found a few other similar requests to other projects when searching drupal.org for "bcc". This project seems like the closest one to being a good fit for adding such a feature. What do you think about adding it here vs its own, or is there an even better option to submit it to?
Comments
#1
Go ahead and submit a patch for it.
#2
I would also like to be able to BCC the mails
#3
Here you go; There's a new option in the settings for silent BCC.
Note that this patch is for the 1.0 release.
#4
Just a few minor things:
The standard capitalizing for "E-Mail" is "e-mail" in Drupal core.
The
} else {format should have a new line after the first bracket, before the else.The watchdog call assigns the t(), third parameter variables to
$variablesinstead of just stating the array. I don't think you need the variable assignment in the parameters. I'd also maybe set that watchdog to be at WATCHDOG_INFO level.#5
Really cool idea.
#6
Thanks moritzz ! This is a useful feature to have. Hope it gets into an official release soon
#7
Here we go with the changes suggested by deekayen. I did not switch to the dev release, because there is a new feature added there I do not need. I am open to port this patch to dev, if the author wishes or the changes made in dev get into a later final release.
#8
Any changes that go in has to be against the -dev release, because of what you said : there are new changes in it and your patch cannot be applied as is.
So, re-roll the patch against -dev, change the version and set it to needs review, and hopefully someone will test it. Once it is confirmed working I will do a code review and then commit it.