Even in a production environment, there have been times where I have wanted to be BCCed on all outgoing emails, just to prove they were being sent. #543022: How do I know if it's working? on inactive user reminds me of that need and I found a few other similar requests to other projects when searching drupal.org for "bcc". This project seems like the closest one to being a good fit for adding such a feature. What do you think about adding it here vs its own, or is there an even better option to submit it to?

CommentFileSizeAuthor
#11 reroute_email-silent_bcc_option-543062-11.patch3.96 KBgarphy
#7 reroute_email-6.x-1.0-reroute_email.module.patch4.6 KBmoritzz
#3 reroute_email-6.x-1.0-reroute_email.module.module.patch3.71 KBmoritzz

Comments

kbahey’s picture

kbahey commented
Status: Active » Needs work

Go ahead and submit a patch for it.

buckley’s picture

buckley commented

I would also like to be able to BCC the mails

moritzz’s picture

moritzz commented
Version: 6.x-1.x-dev » 6.x-1.0
Component: Documentation » Code
Category: support » feature
Status: Needs work » Needs review
StatusFileSize
new reroute_email-6.x-1.0-reroute_email.module.module.patch3.71 KB

Here you go; There's a new option in the settings for silent BCC.

Note that this patch is for the 1.0 release.

deekayen’s picture

deekayen commented
Status: Needs review » Needs work

Just a few minor things:

The standard capitalizing for "E-Mail" is "e-mail" in Drupal core.

The } else { format should have a new line after the first bracket, before the else.

The watchdog call assigns the t(), third parameter variables to $variables instead of just stating the array. I don't think you need the variable assignment in the parameters. I'd also maybe set that watchdog to be at WATCHDOG_INFO level.

univate’s picture

univate commented

Really cool idea.

buckley’s picture

buckley commented

Thanks moritzz ! This is a useful feature to have. Hope it gets into an official release soon

moritzz’s picture

moritzz commented
StatusFileSize
new reroute_email-6.x-1.0-reroute_email.module.patch4.6 KB

Here we go with the changes suggested by deekayen. I did not switch to the dev release, because there is a new feature added there I do not need. I am open to port this patch to dev, if the author wishes or the changes made in dev get into a later final release.

kbahey’s picture

kbahey commented

Any changes that go in has to be against the -dev release, because of what you said : there are new changes in it and your patch cannot be applied as is.

So, re-roll the patch against -dev, change the version and set it to needs review, and hopefully someone will test it. Once it is confirmed working I will do a code review and then commit it.

dydave’s picture

dydave commented
Version: 6.x-1.0 » 7.x-1.x-dev
Status: Needs work » Active

Hi guys,

Thank you so much for all the work on this issue.

This is just a quick comment, as I was going through the issue queue, it seems this has issue has been abandoned for a while and there hasn't been any activity for almost three years now.

As I was going through the previous comments in this issue, it seems that the patch from #7, wasn't accepted because of coding standards and incompatibility with the version/branch, at the time.
But it also appears that @kbahey would have been ready to consider the feature request to be part of the module at some point, if it met the standards and development process from the community.

So, re-roll the patch against -dev, change the version and set it to needs review, and hopefully someone will test it. Once it is confirmed working I will do a code review and then commit it.

It was never re-rolled, but if it had been, @kbahey would perhaps have committed it after going through the testing/reporting process.

Which brings the following questions:
Would anybody be ready to pick this feature request where it was left (at #7)?
Would anybody be interested in re-rolling the patch, porting it to the 7.x-1.x branch or further discussing this issue?

Patches, comments, feedbacks, reviews or questions would certainly be highly appreciated.

Feel free to let us know if you would have any questions, further comments, issues, suggestions, objections or concerns on any aspects discussed in this ticket, I would be glad to help moving this foward.
Thanks to all in advance for your replies, comments and feedback.
Cheers!

garphy’s picture

garphy
Primary language French
Location Montreal, Canada
commented

Cross referencing #1722572: What happens if it's enabled with no email added? as I think that the default behavior of the module when the address list is empty has some impact on the way we should handle that issue.

Regarding this issue, shouldn't we handle that with an option that determine if mail targeted to whitelisted address should still have a copy rerouted or not ?

Also, has we have promising work on #1571500: Separate the recipient (list) from the address whitelist. Add domain whitelist., do we need a separated recipient list for the silent Bcc feature or should we reuse the same list ?

Final tough OTOH : is that feature really belonging to the scope of this module ? We're not rerouting mail here, we're sending (shadow) copy of them. Maybe this is a job for maillog or a new module.

garphy’s picture

garphy
Primary language French
Location Montreal, Canada
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new reroute_email-silent_bcc_option-543062-11.patch3.96 KB

First attempt of rerolling/rewriting things for 7.x-1.x.

bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Needs review » Closed (works as designed)

Hi, @all!

The age of this issue is more than 8 years already.
As we can see, there is no big agiotage around it :)

In general, I totally agree with @garphy. We discuss adding BCC to all outgoing email:
this considered feature isn't belonging to the scope of this module.

I'm gonna to mark this one as `Closed (works as designed)`.
Please reopen otherwise.

Thanks!