The time has come.

All patches iteratively attached here should work - at least considering the main module functionality.

Initial pass.

CommentFileSizeAuthor
#2 img_assist.2.patch15.51 KBsun
img_assist.1.patch48.2 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Some notes:

- This is targeting Image Assist 3.x and is a complete rewrite.

- The patch will also remove the IFRAME in the popup and completely rewrite the JavaScript, also removing all editor-specific code.

- This effort adds a bit pressure on Wysiwyg 3.x (or perhaps also 2.x), because I also want to remove the built-in "button" support for plain textareas (see #421480: Drop "Add image" button in favor of Wysiwyg API). Wysiwyg module should provide at least one (small) pseudo-editor (f.e. markItUp) that supports Drupal plugins and would thereby be capable to expose the "Add Image" button. Alternatively, Wysiwyg could also implement button/link support for the "none" editor (default resizable textarea), but I'm not sure whether it's worth to investigate that (duplication of pseudo-editors).

Perhaps more, but I'm running out of time now.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new img_assist.2.patch15.51 KB

Committed the img_assist.admin.inc separation separately, because that is a minor clean-up not needing further attention.