As already mentioned in IRC, I have added the admin_views module to the admin_menu package.

name = Administration views
description = Replaces all system object management pages in Drupal core with real views.

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/admin_menu/...

Let me first say that this is plain awesome - exactly what one would expect from a real content management system regarding administrative tasks.

However, for that to work properly, I need to be able to replace existing menu router items, which Views does not support currently.

Attached patch adds this option to the built-in page display handler - properly applying inheritance rules for any child router items. To use the admin_views module, you need to apply this patch to views.

I realize that this option may was left out intentionally, or that Views 3.x leveraging CTools's Page Manager might introduce this capability in a different way. However, I'm not sure about the development state of Views 3, and I really would like to push this admin_views awesomeness into the wild.

CommentFileSizeAuthor
#10 views.menu-existing.patch2.14 KBdawehner
views.menu-existing.patch6.21 KBsun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

While debugging some unrelated menu system nightmares, I found a solid way to allow admin_views to override those items without hi-jacking the default menu items. That probably works for 99% of all use-cases. The 'existing' option added here would still be nice to have though.

s.Daniel’s picture

s.Daniel CreditAttribution: s.Daniel commented

tracking

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

I think I still have the basic UI problem that nobody who isn't VERY familiar with both Views and the Menu system will have any idea what this feature means, and people will set it incorrectly and it will screw things up. I understand the value but I think it would be best to have some other way.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Needs work

Thanks for coming back to me! :)

IIRC, we last talked about not introducing this in the "Page" display handler, but instead introducing a new "System" display handler. I think you mentioned that we refer to "system" in a couple of other places already. The only option for this handler would then be a system path - everything else is taken from the menu router.

That sounded also pretty sane to me. If you agree, I'd revamp this patch to accomplish that.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

Well, that's a CTools/Panels thing, and it doesn't do user-created overrides at all.

mariagwyn’s picture

mariagwyn CreditAttribution: mariagwyn commented

I discovered this error b/c after installing Admin Views my admin/user/user/create page could not be found. It isn't clear from this discussion if this is fixed, but I did like the very brief opportunity I had to use admin pages created by views. Alas, it is off now until i know this is fixed. happy to test patches...

maria

sashainparis’s picture

sashainparis
Primary language French
Location Provins
CreditAttribution: sashainparis commented

@Maria: exactly same thing :-(

uufsm’s picture

uufsm CreditAttribution: uufsm commented

This patch fixed that problem of Error 403 for Create User for me. However, I just installed the 6.x-2.7 version of Views, and now I can't install users anymore. Guess I need to repatch. I'm sure hoping that the next version of Views includes this patch.

uufsm’s picture

uufsm CreditAttribution: uufsm commented

I just installed the 6.x-2.8 version of Views, and again I need to add this patch so that I can create Users.

Also, please note that the changes the patch requires at

--- includes/view.inc (revision 687)
+++ includes/view.inc (working copy)
@@ -965,10 +965,14 @@ class view extends views_db_object {

should be done at lines 1008 instead of at 965.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
views.menu-existing.patch2.14 KB

Cleanup version, based on http://drupal.org/node/550132#comment-2080270

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Reviewed & tested by the community

Thanks for helping out!

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Ok, committed to all branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

thebuckst0p’s picture

thebuckst0p CreditAttribution: thebuckst0p commented
Category: feature » bug
Status: Closed (fixed) » Active

It seems this bug is back in the dev releases, tested with the 2011-04-13 and 2011-05-16 releases. I have a users admin view at /admin/user/user, and whenever I submit the New User form at /admin/user/user/create, it redirects to /admin/user/user without any #validate or #submit callbacks firing.
Is there something else I'm supposed to do to make this patch work? Is anyone else seeing this too?

Thank you!

Jamie Holly’s picture

Jamie Holly CreditAttribution: Jamie Holly commented
Issue summary: View changes

For anyone else finding this problem, it seems to exist because admin/user/user/create in users.module doesn't add a page callback. Simple fix is in a custom module:

function {my_module}_menu_alter(&$items) {
    $items['admin/user/user/create']['page callback'] = 'user_admin';
}

Not really sure why core doesn't have the callback set.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Status: Active » Closed (outdated)

The Drupal 6 branch is no longer supported, please check with the D6LTS project if you need further support. For more information as to why this issue was closed, please see issue #3030347: Plan to clean process issue queue