Download & Extend

edit-copy ID is already used by contact.module and breaks XHTML validation

Project:Localization client
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hello, the edit-copy ID used by l10_client module in his form is already declared in form of contact module and that breaks the XHTML validation when these two forms are in the same page.

So i have made a little patch to change id of form elements to avoid this problem (this patch contains also the http://drupal.org/node/361147 patch which adds textgroup support)

AttachmentSize
l10n_client.js_.patch5.28 KB
l10n_client.module.patch5.82 KB

Comments

#1

Version:6.x-1.7» 7.x-1.x-dev
Status:active» patch (to be ported)

Ok, based on similar changes in #616106: When another form contains same ids, client stops working, I've opted to use classes instead. The textgroup support was added in another recently committed patch, so that can be safely ignored here. This however needs porting to Drupal 7 (was just comitted to D6).

AttachmentSize
classify.patch 6.26 KB

#2

Should also add this little change (committing to D6 too):

-  $('#l10n-client #search-filter-clear').click(function() {
+  $('#l10n-client #l10n-client-search-filter-clear').click(function() {

#3

Status:patch (to be ported)» fixed

Patch ported to D7 and found one more occurrence of #search-filter-clear in D6 too. Committing both.

AttachmentSize
ids-to-class-d7.patch 7.67 KB
ids-to-class-d6.patch 905 bytes

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.