Only load img_assist.js when necessary

casey - March 21, 2006 - 13:33
Project:Image Assist
Version:6.x-1.0-beta1
Component:Code
Category:task
Priority:normal
Assigned:sun
Status:duplicate
Description

Move code which loads img_assist.js and other js from img_assist_menu() to img_assist_textarea() so it only will be loaded when neccesary.

#1

Darren Oh - November 28, 2006 - 21:11
Version:HEAD» 4.7.x-1.x-dev

#2

sun - September 7, 2007 - 23:13
Title:only load img_assist.js when neccesary» Only load img_assist.js when necessary
Version:4.7.x-1.x-dev» 5.x-1.4
Priority:minor» normal
Status:active» patch (code needs review)

I second this, that script is quite big and completely useless for most visitors of a site.

AttachmentSize
img_assist-DRUPAL-5_0.patch3.12 KB

#3

zoo33 - September 16, 2007 - 23:47

Looks very reasonable. I'd just like to get some confirmation that everything's working alright quickly before committing. I'll try to test it myself.

#4

mr.j - October 13, 2007 - 06:15

Just subscribing

#5

sun - October 13, 2007 - 17:00
Category:bug report» feature request

#6

TheClue - November 16, 2007 - 21:08

+1. It's definitively a good feature to add!

#7

sun - December 6, 2007 - 21:39
Version:5.x-1.4» 5.x-1.x-dev
Category:feature request» task
Assigned to:Anonymous» sun

#8

sun - April 12, 2008 - 16:22
Version:5.x-1.x-dev» 6.x-1.0-beta1

Re-classifying for 6.x.

#9

zoo33 - June 29, 2008 - 20:19
Status:patch (code needs review)» duplicate

This is also implemented by #246385: Handle teaser splitter, separate JS/CSS which I think is getting close to RTBC.

 
 

Drupal is a registered trademark of Dries Buytaert.