Move code which loads img_assist.js and other js from img_assist_menu() to img_assist_textarea() so it only will be loaded when neccesary.

CommentFileSizeAuthor
#2 img_assist-DRUPAL-5_0.patch3.12 KBsun

Comments

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Version: 6.x-3.x-dev » 4.7.x-1.x-dev
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: only load img_assist.js when neccesary » Only load img_assist.js when necessary
Version: 4.7.x-1.x-dev » 5.x-1.4
Priority: Minor » Normal
Status: Active » Needs review
StatusFileSize
new img_assist-DRUPAL-5_0.patch3.12 KB

I second this, that script is quite big and completely useless for most visitors of a site.

zoo33’s picture

zoo33 commented

Looks very reasonable. I'd just like to get some confirmation that everything's working alright quickly before committing. I'll try to test it myself.

mr.j’s picture

mr.j commented

Just subscribing

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Category: bug » feature
TheClue’s picture

TheClue commented

+1. It's definitively a good feature to add!

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 5.x-1.4 » 5.x-1.x-dev
Assigned: Unassigned » sun
Category: feature » task
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 5.x-1.x-dev » 6.x-1.0-beta1

Re-classifying for 6.x.

zoo33’s picture

zoo33 commented
Status: Needs review » Closed (duplicate)

This is also implemented by #246385: Handle teaser splitter, separate JS/CSS which I think is getting close to RTBC.