PHP undefined variable notices

Configuring settings.php is not sufficient apparently (I had done that a long time ago already and had given up because I didn't get to see any notices).

You must also patch Drupal core: it won't show E_NOTICE errors out-of-the-box. Stupid!

I'll review your patch ASAP :)

I fixed all notices that I could find/produce. I'm sure there are more, although most notices should be fixed now. I've based my patch on your changes, but changed some of your modifications and added many, many more fixes.

http://drupal.org/cvs?commit=281808

Oh and the changes to core that are necessary: in common.inc, change:
if ($errno & (E_ALL ^ E_NOTICE ^ E_DEPRECATED)) {
to:
if ($errno & (E_ALL ^ E_NOTICE | error_reporting())) {

Dammit, this patch consists of very simple changes and therefor I went ahead and committed it. But apparently this broke HS.

Fixed again: http://drupal.org/cvs?commit=281956. Also fixed another notice at the same time.

This fix introduced an error in hs_taxonomy.module:

@@ -135,14 +135,14 @@ function hs_taxonomy_form_taxonomy_form_
       'status'   => 1,
     ),
     'params' => array(
-      'vid'         => $form['vid']['#value'],
-      'exclude_tid' => $form['tid']['#value'],
+      'vid'         => isset($form['tid']['#value']) ? $form['vid']['#value'] : NULL,
+      'exclude_tid' => isset($form['tid']['#value']) ? $form['tid']['#value'] : NULL,
       'root_term'   => TRUE,
     ),
   );

I think you meant to use:

'vid'         => isset($form['vid']['#value']) ? $form['vid']['#value'] : NULL,

Otherwise the parent and related terms in new terms form will always be empty.

Good find. Thanks! Will commit ASAP.

jrao, sorry for not committing your fix right away. This was solved in #640418: Unable to select parent terms on add term form though, many weeks ago. I hope you saw this was "suddenly" fixed :)