Posted by philipnet on August 20, 2009 at 5:53am
Jump to:
| Project: | Mailhandler |
| Version: | master |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Hey,
I know this is early and we haven't even reached code freeze for Drupal 7, but as the maintainer of Listhandler (which is some sort of bastardised twin of Mailhandler ;) ) I'm curious to know if the maintainers have given any thought to a Drupal 7 version of Mailhandler?
Are they planning to release a D7 version on the date D7 is released?
Or if they're thinking of giving D7 a few months and then releasing a version?
Or perhaps they haven't given it any thought and it doesn't appear on the radar at all!
Cheers.
Phil L.
Comments
#1
Hi Phil,
The truth is that I am currently unable to /properly/ maintain this module. There are few important tasks in the current version, that I don't get to do, and it seem to me a bit more important than a D7 version, important as it may be.
I will probably turn to few people soon, and propose them to take the lead in mailhandler maintenance.
#2
I'm interested in seeing this module move to D7 for the Sensor Hub project I'm working on http://sensorhub.org/wiki/. Is anyone currently planning on porting this to D7?
#3
I'm not ready for D7 myself, however mail handler is essential for a lot of people and if there is no d7 after a few months I'll make sure I somehow make a d7 version of the 1.x version no doubt with help from the Drupal community
#4
Would a bounty help achieve a Drupal 7 port? If so, how much?
#5
@cor3huis ideally only the 2.x branch will be upgraded to D7. Let me know if you'd like to coordinate toward this goal.
#6
I agree, ideally yes, however realistically, D7 is here and no mailhandler and the differences with v2.0 are enormous and Mailhandler v2 is still in flux. That is why I'm pragmatic and would like to see v1 first, conversion would be straightforward. Not that I do not like v2 personally, but I like to have working software first ;) and also the effort to other modules depending on Mailhandler mostly use v1.x. e.g. the all important Listhandler would be huge. Thus threfore not to leve Drupal uses without options of a real working solution I prefer v1. first
#7
@mkmckinn - Sure it would help, but not for me since I have other obligation at this moment. Better still I also would donate too if someone converts Mailhandler v1 to D7 soon.
#8
@Ian Ward >Let me know if you'd like to coordinate toward this goal.
Great offer,thx, need however to finalize the fix I've made for Mailhandler DateTimestamp in for retro data first. Then I will be on to fixing the Listhandler Threading issue with retro data and then Implementing adding the Listhandler user creation DateTimestamp to the DateTime of first post of Retro data. After that I hope to finally be able to start using a Drupal install...
IMHO we all be merrier cleaning the issue backlog a little more, there I help in between other tasks, wherever I can.
#9
@cor3huis my point is that part of the reason 2.x is still in some flux is because of the legacy of 1.x. I see what you are saying about upgrading 1.x, but, those same efforts could go toward stabilizing 2.x instead of upgrading a platform that's inherently difficult to work with and extend, which would result in upgrading fundamental problems to 7.x.
I'll clean up the 2.x queue and make sure all the remaining tasks are clear in the next few days.
#10
Hey!
Just started to port mailhandler 2.x-dev to Drupal 7.
But hung now on several places and stopped. I'd like to discuss the functional operations of Mailhandler 2.x, because i do think it will get much smaller as a D7 Module.
If you can get me some overview about what the requirements are, I'd love to rewrite it for D7 and use it there.
#11
@Christian and Ian, Fantastic initiatives. Yes, I see the 2.x for D7 reasons are very valid, I was just over worried about listhandler I bet.
#12
@Christian and Ian, awesome and thank you. I'm willing to help, but my PHP coding skills are between poor and non-existent. How could I best contribute?
#13
@Christian Fischer where are you stuck specifically? Also, what are your goals with rewriting the module, and why not just upgrade it to D7? Do you see specific problems which should be rewritten?
@anyone who wants to help w/ 2.x upgrading to D7, there are a couple D6 major issues, namely #947266: Consider how to handle comments and #883936: Write 1.x to 2.x upgrade script which either need a patch or need testing.
@mkmckinn testing the D6 2.x branch will help, as well as creating issues for anything you run into be it bugs or usability issues or improvements, or improving documentation on how to get set up.
2.x is quite close to an alpha. A lot of code and inline documentation needs cleaning up and there are still a few tasks I need to create tickets for, but it is mostly working. Ideally efforts can be focused on stabilizing and finishing D6 2.x, and also upgrading 2.x to D7.
Anyone looking to totally rewrite, we should talk. Maybe there's a good reason. The mailhandler.retrieve.inc library is something I have touched little of besides making it not open a new imap stream per email message which was fixed over a year ago. Perhaps that code could really use some cleaning up, but I've not focused efforts on the library beyond the stream handling.
#14
Here's another important task which is going to help out a lot with newcomers to mailhandler 2.x, as well as newcomers to feeds #1023928: Create a default feeds importer for mailhandler ... someone could take ownership of this one too.
#15
I went through the code and created issues for 2.x. Issues marked as "major" should happen before an alpha release. Overall, it's not a ton of work, but there are some important tasks. http://drupal.org/project/issues/mailhandler?text=&status=Open&prioritie...
#16
I did a rewrite/redo (called email_harvest - zip at http://drupal.org/node/1011562#comment-3935986) because I wanted to use d7 and needed something up and running quickly (project due in 8 days...). But the primary reason was I could not get the imap import to save attachments. I see your post on having that fixed this morning. The setup/instructions are very confusing or non-inuitive (do I need mimedetect? mailsave? what else?) and the code was difficult to follow and identify dependencies. The comments in the discussions were all over the place on what/how to fix. Also, the copy I had downloaded opened connections several times through the fetch>parse>process. And finally, my post to this list went unanswered during the time I decided to rewrite. I mention this to point out my experience, not to be critical.
On the module:
I do most of the work in the fetcher result and broke out the functionality in a bunch of methods so they could be overridden at convenient points. The parser is very simple as it just takes the data gathered by the fetcher and prepares it for the standard feed's node processor. If there is anything you can use from that code, feel free to grab.
#17
@Ian Ward: Was too much code for me and stuck in admin forms to add mailbox. I did not use mailhandler in a 6.x enviroment - so it is hard to understand the basic concepts.
With D7 i love the Rules-Module. I did already write a mailman-Module which implements only the four Actions Subscribe, Unsubscribe, create and delete a mailinglist. Did hook them up to work with Organic Groups. So every og has its own list.
Now my scope would be to "sync" Mailinglist-Entries with Forum entries hooked to the OG or even easier: posting Comments to this OG-Node from/to Mailinglist.
Imho Mailhandler module should implement some Events like:
- new Mail
- Mailhandler-handled contenttype posted
And actions like:
- send email for mailhandler node/forum
This way it should be more flexible for everybody to integrate mailhandler into various enviroments.
Am i missing something?
So - currently the most important thing is the 2.x Documentation. So i do know where/if i can hook into with my approach.
#18
I will install the 2.x MailHandler on D6 and start testing.
#19
Subscribing - I'm also tackling the issues in #13 as time allows
#20
waiting for d7....
#21
@babbar.ankit , instead of waiting, maybe take a look at the issue queue and try fix some simpler support issues of task so our issuelist will be more clean and the sooner ans improved list and mailhandler will be a reality.
#22
Subcribe
#23
#24
Is the 6.x-1.x branch planned to be also ported to D7? or do I start doing this.. I have a site being upgraded and require this module. If someone kindly create the branch I'll start submitting patches.
#25
@Ilo, yes, that would be very much appreciated. Maybe first integrate the patches I've created for 1.x then a D7 v1.x branch. Helpful to make it happen is using Deadwood http://drupal.org/project/deadwood and Coder wherever it make our conversion life simpler.
#26
@cor3huis, as long as the site I'm working on is being upgraded to Drupal 7 (and it is happening right now) hardly I can arguee the customer to keep working on the 6 branch: this is the only site I have using mailhandler. I'm just asking for a CVS branch to be able to attach the patches we have created during the upgrade.
Unfortunatelly right now I'm busy enough to work on the d6 issues, but probably I can spend some personal time once I finish the job, however I wont have a live testing site to verify changes, only a local dev environment.
#27
sorry, s/can arguee/can't arguee/
#28
It's all fine with me, just wanted to do a favor letting you know about the improvements ahead of time. They improvements will be in the D6 1.x in the future anyhow, you can then port them to your D7 1.x version if you want.
For Now I think best is to make a separate issue named "No Mailhandler 1.x for Drupal 7 available" and work from there. Set it to "needs work" and as "Task" and assign to yourself for the initial version.
Ask Ian(maintainer) to be a co-maintainer for the time you are busy with D6 1.x to D7 1.x.
Thanks for you initiative to make a 1.x port to D7 a reality, really great!
#29
@cor3huis, looks like I'll be doing some cleanup tasks on the 6.x-1.x branch before going for the Drupal 7 during this days. Any chance to get you involved is appreciated. I just need you to point me to the issues you have considered for inmediate review, and I invite you to review the issues I'll be creating in that branch.
#30
@ilo, the issues and fixes involved
#1000440: Mailhandler comment created and changed date and time stored incorrectly
#1032686: Issues read from mailserver out of order prevent correct threading
And maybe re-check if this one was really inplemented in 6.x, just to make sure.:
#1037086: function imap_header should be replaced by imap_headerinfo
If you convert it would be a good idea to run the module throught the "Coder" script and see what is missing of e.g comments and see what can be added.
I propose to move this discussion now to #1037560: Create DRUPAL-7--1 branch in CVS and (not published) release node
and make it a bug and rename to e.g. "No Mailhandler 1.x for Drupal 7"
#31
Has anyone actually put any effort into a 7.x-2.x port? I might need this fairly soon, and if no one has started on a port I just might. But it would be good to know that I'm not duplicating effort.
#32
@Dane Powell , see in this issue the comment [#comment-3920668]. Indeed duplicating effort would be a waist of your knowledge. I advise to request Ian to become a co-maintainer. There can be more co maintainers than one IMHO, then you can post improvements. Advised is to not add new features but get it working first for D7
#33
I've made a first pass at a D7 conversion and created a 7.x-2.x branch. It's almost certainly not working (at least not completely), but I haven't had a chance to test yet. I would have preferred to wait until more progress was made on a 6.x-2.x release, but it's becoming fairly urgent for our project to get a D7 release out the door.
Remaining action items:
- Address all todos in code
- Do some basic testing
- Keep in mind that there are now two 2.x branches, and remember to port future patches between the two
#34
Yikes... well, not surprisingly, it's not working. To start with, try to add a mailbox and you'll see that no form is loaded. I suspect something in the CTools API has changed to cause this- it's not able to find the MailhandlerMailbox class. But I really don't know anything about ctools in the first place, so I'm having trouble finding the cause.
#35
Great that you started on a Branch for D7!
Q: is it a personal Git repo or can we access your branch via main Repo?
( Not using D7 for a while myself I bet, however it's much wished for feature for other I bet).
Q: BTW can you not use a D7 version of v1.x , what functionality do you need of v2.x?
#36
It's in the Drupal repo. I don't suppose we strictly need 2.x over 1.x, but since 2.x is "the future" I'd rather build on that if possible, rather than starting on 1.x and having to upgrade later (especially since an upgrade path seems slow in coming)
#37
I just checked out the repo from d.o and I see you just have a 7.x-2.x branch. It would be good to have 6.x-2.x and 6.x-1.x branches in there as well. For 6.x-2.x it looks like you can checkout 84b50134e3d7b8809de3ff90976a3c89d08e76ad, branch to 6.x-2.x, commit it, and that branch will be preserved. Not sure about 6.x-1.x. Could just download the tarball but it would be a shame to lose the CVS history. Where did it go :-P ?
#38
@rjstatic ?? Check again, they've always been there...
#39
@Dane Powell: lol my bad. I just copied and pasted the git clone line from here without paying close attention http://drupal.org/project/mailhandler/git-instructions
#40
@Dane Powell, maybe there is no 1.x to 2.x automated, but upgrading only means creating the old accounts by hand, I understand your worry nonetheless. Personally v2.x is not my preferred version and IMHO not comparable to 1.x at the moment. But all that does not really matter, I'm happy attention is given to whatever version ;) for D7
#41
Just FYI, I figured out the problem with ctools (and cleaned up a bit of bad code in the process): http://drupal.org/commitlog/commit/96/a47d0d6b354cb430036c332368981fd9ba...
I also ported these changes back to 6.x-2.x.
Work still needs to be done- I won't be able to take another look at it until Monday.
#42
An initial dev release will drop today. Let the testing begin!
#43
Thx, will do, shame on me that I'm quite busy so it will take a while before I have results though. So for all others Dane and everyone involved did the Drupal community a great favor. Return the favor by testing and give feedback.
#44
Hi,
thanks for development of this module and for starting D7 port!
I installed the module yesterday on D7 and can successfully set up a POP3 mailbox - I get the message "Mailhandler was able to connect to the mailbox".
But then, I cannot find any link to start retrieving e-mails, so I am stuck. There is only activate, deactivate, duplicate, export, edit and delete.
Another question is: In configuration, there is no field for default configuration (commands). Is this correct? I read about such a field in some great tutorial-style documentation.
I have no node type "blog" but just one named "article", so I would like to preconfigure this... and perhaps some other options as well...
#45
Read the README included with the module and linked to from the project page.
#46
Automatically closed -- issue fixed for 2 weeks with no activity.