Jump to:
| Project: | Flickr |
| Version: | 6.x-1.x-dev |
| Component: | flickr_field |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
Motivation
For some users, entering the flickr id for an asset (photo or photoset) is not intuitive. When adding an image, the user should be able to see what they are adding before submitting the form.
In this patch
This patch comprises an unobtrusive, ahah-paginated javascript flickr image browser for flickrfield, with support for photos and photosets, along with some trivial standards compliant updates to existing flickrfield code.
Flickr Browser is...
... disabled by default and adds a widget setting checkbox to the content type edit form.
... based on unobtrusive javascript to populate the existing flickr id field when an image is clicked.
... compatible with existing flickrfield cck fields.
Flickr Browser is not...
... intended to change the behavior of flickrfield in any way.
Dependencies
ahah_helper
wimleers' patch to teaser.js
| Attachment | Size |
|---|---|
| flickr-browser.patch | 31 KB |
| screenshot.png | 171.94 KB |
Comments
#1
The functionality is very nice, I like the browser. Here are my observations after trying this.
Creating a photo: (cool)
After hitting submit: (not cool)
The errors in the second screenshot are due to a javascript error concerning the patch you recommend applying to teaser.js. After reverting that patch, the error goes away but I am still at the /node/add/photo page after submission.
#2
thanks for reviewing, sirkitree.
I think all the issues you mention are rooted in a bug with ahah_helper: #513322: Not being redirected after node creation or edit
That issue vexing and perplexing, and I'm not sure the best way to address it.
Unless someone else has some ideas on how to address #513322, I'll try to take a whack at it soon.
#3
I believe this patch will work much more smoothly with this patch to ahah_helper:
#688210: patch to fix bugs using ahah_helper in a CCK widget
#4
Hey, Aaron
This looks awesome!
Were you able to resolve your difficulties ?
Best,
Paul Booker
#5
Paul:
Like I said, this patch works great for me after applying the fixing the bug in ahah_helper.
I've been using it on production sites since my original post with no real issues.
Did you give a try?
#6
Hi Aaron,
I shall try out these new features when the related bugs with ahah_helper have been resolved.
Best,
Paul Booker
Appcoast
#7
Has anything new happened with this patch? I'm a newbie and am looking for some help. I installed this patch, enabled the browser, and can see the photos/photosets in my flickr create content page. My issues is that when I select a photo, it's not updating the ID field. I'm assuming this is a javascript problem but am not sure where to go from here. I really want to get this working, so any help would be awesome. Thx.
#8
Thanks for the work this worked great.
#9
Witch version of flickr should I use?
I am unable to patch 6.x-1.2 and 6.x-1.x-dev (following Error).
patching file flickrfield.infopatching file flickrfield.module
Hunk #14 FAILED at 391.
Hunk #15 succeeded at 449 (offset 25 lines).
Hunk #16 succeeded at 468 (offset 25 lines).
Hunk #17 succeeded at 488 (offset 25 lines).
1 out of 17 hunks FAILED -- saving rejects to file flickrfield.module.rej
patching file flickrfield.css
patching file flickrfield.js
Can anybody post his working version?
Martin
#10
m0rtel, I was on the same boat - you might want to check out this module:
http://drupal.org/project/flickrbrowser
Just make sure you're using jQuery 1.3 or above.