Site-wide contact form tests failing on PHP 5.2.9 [#558534]

Here's a fun one. Apparently there was a change in FILTER_VALIDATE_EMAIL as of PHP 5.2.9 that causes the site-wide contact form test to fail. Here's the line that's causing the fails:

$invalid_recipients = array('invalid', 'invalid@', 'invalid_recipients.', '@site.', '@site.com');

If I remove the '@site.' so the line reads:

$invalid_recipients = array('invalid', 'invalid@', 'invalid_recipients.', '@site.com');

all the tests pass.

I've tried running the tests as they are in HEAD on PHP 5.2.6 and they pass with no change. I imagine this change is also present in PHP 5.3 as well, but have not yet verified that.

I have attached a patch that fixes this.

Comment	File	Size	Author
	sitewidecontact.001.patch	1.02 KB	karschsp

Comments

Comment #1

karschsp commented 25 August 2009 at 01:45

Status:

Active

» Needs review

one of these days i'll remember to set the status!

Comment #2

karschsp commented 25 August 2009 at 01:47

oh and here's the link to the bug on php.net: http://bugs.php.net/bug.php?id=47282

Comment #3

deekayen commented 14 November 2009 at 04:34

Status:

Needs review

» Reviewed & tested by the community

Seems to me the tradeoff here is that you tell people not to use 5.2.9 or remove the offending sample. Fedora 11, Mandriva 2009.1, PCLinuxOS, FreeBSD 7.2, NetBSD 5.0, Frugalware Linux 1.0 all prepackage with 5.2.9, so that seems like a big enough pool of users to not ignore.