Class for active links in summary view attachments

Here is a initial patch. I'm not sure whether this is fine and good to use for the themers :)

I don't really like using l() in a template. Can we just have the preprocess do the active check and throw that in a classes variable instead?

Subscribe.

Meanwhile, i've used jQuery for a temporary fix. Works only with AJAX disabled (reads url) Maybe this helps.

Views default glossary:

   $(".view-glossary.view-display-id-attachment span a").each(function(){
     if($(this).attr("href") == location.pathname) {
       $(this).addClass('my-class');
     }
   });

or custom glossary attachment, I styled mine like primary tabs.

   $(".view-myview .views-summary li a").each(function(){
     if($(this).attr("href") == location.pathname) {
       $(this).parent().addClass('active');
     }
   });

+subscribe

I would like to see an easy way to do this for a block item's active trail. The 'a' tag appears to get the active class, but the 'li' tag in a block doesn't get the active-trail class so it's hard to style bullet items for the currently active page.

In the meantime, I used a slightly modified version of the jquery code from #7.

<script>
$(document).ready(function() {
  $("li").each(function(){
    if($(this).find('a').attr("href") == location.pathname) {
      $(this).addClass('active-trail');
    }
  });
});
</script>

I'd really like to do this the drupal way, but at the same time, it's hard not to notice that doing it with jquery is short, understandable and fast. The drupal way apparently involves the interaction of several modules, a tangled webs of template files, template preprocess functions, the stacked nature of Drupal API's and on and on.

It's things like this that really make me question my investment in Drupal, which seems sometimes to be a towering mess of modules, functions, overrides, templates and hundreds of SQL queries to generate a single page.

Here's my stab at it, using a preprocess function and modifying the template.

dboulet - your patch was pretty much right on for formatted summary view, however it also needs to apply to the unformatted summary view, or the default glossary view doesn't seem to work (at least for me).

I added to your patch to enable this to work with unformatted.

Great work! Committed to all branches.

Great! Thanks for the help CrashTest_.

The patch listed in comment 10 worked great for me, but it didn't handle the situation of a default. So for my view, I wanted the first item to have the 'active' class in the default case. I did this by implementing a preprocess function in my theme:

function MYTHEMENAME_preprocess_views_view_summary(&$vars) {
  if (sizeof($vars['classes']) == 0) {
    $vars['classes'][0] = 'active';
  }
}

I think you may also need to have your own template file overriding the default views one (views-view-summary.tpl.php) for drupal to find and call your function. In my case, I overwrote it for a specific view (so I added the file views-view-summary--VIEWNAME.tpl.php) because I also wanted the active class on the containing list element not the link.

I experienced problems with differences between the url comparison on a Catalan site with aliases like "Alòs d'Isil".

This follow on patch runs the urls to be compared through rawurldecode (perhaps there is a better way?).

I would like to have documented why here rawurldecode is used....

Replaces patch at #15 using drupal_urlencode and only on incoming path. Comment added.

This resolves my case as in:

$vars['rows'][$id]->url  = /map/mercat/producte/Al%C3%B2s%20d%27Isil

base_path() . drupal_get_path_alias($_GET['q']) = /map/mercat/producte/Alòs d'Isil

Sorry but why?
You only describe what you are doing, which is already covered nice by the function name

@dereine:

I made the patch at #558602-17: Class for active links in summary view attachments because:

I have summary lists of taxonomy term arguments. I noticed that the "active link" functionality was only being set when the "active link" was a single word with no space etc.

Upon investigation, I saw that the comparison to find the active link:

if ($vars['rows'][$id]->url == base_path() . $_GET['q'] || $vars['rows'][$id]->url == base_path() . drupal_get_path_alias($_GET['q']))

was trying to compare, for example:

"/map/mercat/producte/Al%C3%B2s%20d%27Isil" == "/map/mercat/producte/Alòs d'Isil"

(substituting the comparison with an actual example obtained from an xdebug session).

On the one side, the value has already been passed through drupal_urlencode in the url() call, so I perform a drupal_urlencode on the other side in order to compare like with like.

Does that make any sense at all?!!

dereine means that the why should be in the comments in the code.

Whenever the reason for something is unclear or ambiguous, that is an opportunity to apply good code comments. =)

This replaces patch at #558602-17: Class for active links in summary view attachments, hopefully with better code comments.

Patience of all concerned much appreciated.

This replaces patch at #558602-17: Class for active links in summary view attachments, hopefully with better code comments.

Patience of all concerned much appreciated.

Link to patch above doesn't work for some reason.

http://drupal.org/files/issues/views-Drupal-6--2_558602_drupal_urlencode...

None of these patches fix the issue I currently have: with one or more exposed filters, the active class doesn't get attached to the summary attachment because if I have exposed the body field filter, URLs will look like /map/mercat/producte/Al%C3%B2s%20d%27Isil?body= while the patch #10 (currently in Views 2.10) and the latest one in #25 will both ignore the filter hence this fix won't work.

I will try to add a patch as soon as I get it fixed.

I'm not sure how filters tie in to an active class?

Well Earl, the method currently used to evaluate the status of a link being active or inactive depends on comparing the $_GET['q'] to the link's URL and ignores the other parameters in $_GET.

Without exposed filters:
$vars['rows'][$id]->url = '/example/myview/A'
$_GET['q'] = '/example/myview/A'
Result: the link has the class active.

With exposed filters (body field in this example):
$vars['rows'][$id]->url = '/example/myview/A'
$_GET['q'] = '/example/myview/A?body=ape'
Result: the link doesn't have the class active though it should.

$_GET['q'] = '/example/myview/A?body=ape'

$_GET['q'] should never include query parameters.

Sorry, a typo.

With exposed filters (body field in this example):
$vars['rows'][$id]->url = '/example/myview/A?body=ape'
$_GET['q'] = '/example/myview/A'

Ok, so we need to add a parse_url() in there. Got it.

I am sorry, it doesn't work with multilingual websites.

Here is the reason:

$vars['rows'][$id]->url = /mysite/de/my_favorites/by_language/9/de
base_path()             =            my_favorites/by_language/9/de
$_GET['q']              = /mysite/

==> the de is missing and thus the link is not getting highlighted

Proposed solution: use the url() function instead of concatenating the url fragments. It takes the language into account.
Use this ...

    if ($vars['rows'][$id]->url == url($_GET['q']) || $vars['rows'][$id]->url == url( drupal_get_path_alias($_GET['q']) ) ) {
      $vars['classes'][$id] = 'active';
    }

instead of this

    if ($vars['rows'][$id]->url == base_path() . $_GET['q'] || $vars['rows'][$id]->url == base_path() . drupal_get_path_alias($_GET['q'])) {
      $vars['classes'][$id] = 'active';
    }

So

Please see my comment #32 -> http://drupal.org/node/558602#comment-2863094

No work done for more than 3 months

Subscribe

Subscribe

No work width Drupal 6.20 Views 6.x-2.12

Ok sorry, see comment #32!

any update on this?

How Do I apply class "active" to default argument of attachment. ?

subscribe

If just a quick frontend fix is needed, the active link class could also be set with a simple jquery command, that compares the href attribute to the actual URL.

Oh I see, someone already proposed that on #7

Reviving :)

Created a proper patch based on #32 which fixes this for me (multilingual site)

Just an FYI for anybody looking for this on the 7.x branch. I found a working patch here. https://www.drupal.org/node/2159967

Patch in comment #41 applies without difficulty to latest views-6.x-2.26

The Drupal 6 branch is no longer supported, please check with the D6LTS project if you need further support. For more information as to why this issue was closed, please see issue #3030347: Plan to clean process issue queue

How will I achieve the same if the glossary view is in AJAX enabled? I am using Drupal 9.