As was mentioned in #550278: Support hook_diff() to show changes across revisions, AbstractQuizQuestionResponse doesn't contains 'implements' string. I've wrote my own question type, and I don't want to use AbstractQuizQuestionResponse, but the QuizQuestionResponse. So, I have several problems with default arguments in __constructor and in formatReport. It looks like now the default arguments are used only in quiz_question.theme.inc, so I've corrected calls in that file.

In the Quiz-4 this problem is fixed by adding default arguments to the interface. Maybe, you should commit some changes to the Quiz-3 too? If it won't cause any problem, the same changes as it was done for quiz 4 can be done.

The patch, which adds default arguments to interface, is attached. Note: it's not tested.

CommentFileSizeAuthor
quiz-question-core-design.patch1.07 KBdpantele

Comments

mbutcher’s picture

mbutcher commented
Status: Needs review » Needs work

If the patch is untested, I won't do anything with it. Please test and then update this ticket.

Matt

turadg’s picture

turadg commented

This seems safe since it's the same as was done in 4.x. Note though that the patch is backwards. (PanDa777, it patches _from_ your revised version back to the broken version.)

Still, it would be best to test it in 3.x since there may be critical differences between 3 and 4.

dpantele’s picture

dpantele commented
Status: Needs work » Fixed

It looks like it was fixed in last 3.x-dev...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.