While a patch attachment works for any subsequent replies to issues, the current version of Project module running on Drupal.org loses the file attachments.

Comments

dww’s picture

dww
we/he/they
commented

i can reproduce this on a local cvs test site, too, so it's definitely a bug in project, not something weird with drupal.org...

dww’s picture

dww
we/he/they
commented

i'm pretty sure the problem lies in project_issue_node_form_validate(), with these lines:

      $file = file_check_upload('file_issue');
      $form_values['file'] = file_save_upload($file);

we shouldn't be trying to modify $form_values from inside validate() without a #ref (see #56959). chx pointed me to the comment_upload module in contrib as an example of how to do this kind of thing correctly... i still don't have time to roll a patch, so if anyone else wants to take this, please do!

thanks,
-derek

Anonymous’s picture

Anonymous (not verified) commented

is this one still alive? i can't reproduce it.

dww’s picture

dww
we/he/they
commented
Status: Active » Closed (fixed)

weird, i don't know what changed that could have fixed this, since the suspicious code in project_issue_node_form_validate() is still there. but yeah, it seems to be working fine on d.o and on a local 4.7 test site again. strange.