When I click submit with an empty status it's posted with no status and no time in Latest Status Updates view. I do not know if this is the desired behavior...

I can avoid it by coding in facebook_status.module in line 700 this:

 if ($new_status != $status->status && $account->uid && ($new_status != '')) {

If you think this is a 'bug' could be better to fix this in future releases. Instead, If you think isn't relevant, must I rewrite this line all the times I update the module? (or there's a way for overriding this function of facebook_status.module)

Comments

icecreamyou’s picture

icecreamyou commented
Status: Active » Reviewed & tested by the community

Just add the "Facebook-style Statuses: Status Text" filter to the View for now and leave the matching textfield blank in the filter options. I did that for the other default Views but I must have forgotten to do that in the Latest Status Updates view.

icecreamyou’s picture

icecreamyou commented
Status: Reviewed & tested by the community » Fixed

Fixed in CVS. You will need to go to admin/build/views and click "Revert" next to the relevant view in order to see the changes. You may also need to refresh your Drupal and/or Views cache.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

wilgrace’s picture

wilgrace commented

I've found that if you include any Default text (under Advanced settings), and a user clicks Submit on their Status, that text is submitted - as a result I get a lot of 'What's on your mind?' status updates

Is there any way to prevent this?

icecreamyou’s picture

icecreamyou commented

I just committed a fix for that to CVS, and it will be in the next dev. If you urgently need a fix for this in the mean time and you don't know how to use CVS, you could always just add a filter to your view(s) excluding statuses with your default text.

wilgrace’s picture

wilgrace commented

Ouststanding, thanks. I'll pick up from cvs

JulienD’s picture

JulienD commented

Hello IceCreamYou

I've got the same problem with the latest version of the module (6.x-2.1) that allow to post empty statuses.

Did you not committed a fix for that ?

publicmind’s picture

publicmind commented

clear caches!!

JulienD’s picture

JulienD commented

Thx for your board but clear caches did nothing and I don't see what can it do ?

icecreamyou’s picture

icecreamyou commented

See comment #2:

You will need to go to admin/build/views and click "Revert" next to the relevant view in order to see the changes. You may also need to refresh your Drupal and/or Views cache.

The change that was committed just adds a filter to the relevant View to exclude blank statuses. If you don't see that filter, you need to revert your view, or you could just add it yourself. It's Views. It's designed to be easy for you to change.

...and you would be shocked at some of the ridiculous problems caching can cause

JulienD’s picture

JulienD commented

Ok, it's only for view. I missed that : /

My problem is that an empty status create an empty activity and people can flag empty activities. I will be oblige to find a way to prevent the creation of activities.

Thx

icecreamyou’s picture

icecreamyou commented

You can still avoid that with a filter, but I just changed the code in -dev so this should no longer be a problem.