Drupal has built-in permission for editing own comments until someone replied to that comment.

After installing Forum Access module, comments in a Forum cannot be edited by owners. Disabling Forum Access restores possibility to edit own comments.

I set following permissions:
- in Forum Access - "view" and "post" rights for authenticated users in /admin/content/forum/edit/forum/[num]

What is more, when enabling "edit posts" right in Forum Access - authenticated users gets permission to edit and delete ALL comments (sent by different users).

I did not find solution for this problem. Anyone can help?

Comments

lewmich’s picture

Title: Global built-in permission "edit own comment" rights overridden » Global built-in permission "edit own comment" overridden
salvis’s picture

Category: bug » support

As it says under Permissions information:

Note that users need

  • the post comments and (probably) post comments without approval permission AND Post to be able to post comments/replies;

Also, Edit is 'edit', not 'edit own.'

Everything is working as designed and documented.

lewmich’s picture

1. In my case edit also gives rights to delete replies - which should depend on delete permission in Forum Access - this is a BUG in my opinion. Isn't it?

2. In my opinion, when users are not granted in Forum Access with edit permission (permission to edit all posts), they should still be able to edit their own replies - according to global, standard Drupal settings for comments. This functionality should not be shut down by Forum Access module. Is it a bug or functionality request?

Maybe there is something specific in my Drupal instalation that it works this unusual way... But I have not found anything...

I will appreciate your help!!

salvis’s picture

Yes, #1 would be a bug — I'll look into it.

#2 is a feature request, but so far it hasn't found overwhelming support.

I'm at DrupalCon right now, give me some more time...

SuperContraXTC’s picture

Thanks for informing me it is a BUG. I went crazy trying to figure what was wrong with my site.

salvis’s picture

Category: support » bug

Indeed, I find that the [Delete] button is visible, even though the user only has Edit rights. However, it doesn't actually work: I get an Access Denied message, when I click on it. IOW, this is a cosmetic issue, but it still needs to be fixed, of course.

lewmich’s picture

Thanks Salvis for your reply. I hope that it will be possible to fix this bug.

I will also really appreciate if it will be possible to let users edit their own comments. As I already said it is a standard, global drupal permission and in my opinion it should not be overridden by the Forum Access module.

Thanks for help!

m.

flebas’s picture

Hello,

I also would appreciate to keep "edit own comment" permission working with forum access.

Regards,
Frederic

salvis’s picture

Title: Global built-in permission "edit own comment" overridden » Ability to edit own unreplied-to comments lost

I also would appreciate to keep "edit own comment" permission working with forum access.

Is the edit own comment permission not working?

I'm under the impression that the OP was referring to Drupal always allowing to edit your own comment as long as no one had replied to it, irrespective of the edit own comment permission. I haven't actually verified yet that Drupal (without FA) really does behave that way.

I've corrected the title, since this is not about a permission at all.

@flebas: if you really mean "permission", then please open a new thread.

salvis’s picture

Title: Ability to edit own unreplied-to comments lost » Allow editing own unreplied-to comments even without permission
Category: bug » feature

I've just committed a fix that removes the unusable [Delete] button (among other things). Give it up to 12h to be repackaged.

This removes the bug part of this issue. What remains is a feature request — I'm still working on clarifying the title...

(Having more than one issue in a single issue thread is a pain!)

salvis’s picture

Category: feature » bug
Status: Active » Fixed

#597616: Edit link not displayed on own comments made me realize that it's a bug after all.

Committed to 6.x-1.x-dev — give it up to 12 hours to be repackaged, and let us know how it works.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

davidteall’s picture

Status: Closed (fixed) » Active

I know this is an old thread, but I am now struggling with the same problem.

Drupal Core behaviour is to allow Users to edit a comment until someone makes a comment on that comment. I have tested this. This is sensible behaviour. Users often want to correct a typo or re-phrase something and this allows them to if they are quick. Preventing editing once a further comment has been made is also sensible as editing a comment that others have already commented on could make it impossible to follow a thread.

FA over-rides this core behaviour without replacing it with an alternative so it is impossible for users to edit their own comments. I have many users complaining about this and I can't put it right.

Actually, the ability to edit is not removed - it's the link that disappears. If you edit the URL to /comment/edit/xxx where xxx is the comment id, the edit page comes up.

Content Access deals with this question by having 'edit own posts' and 'delete own posts' as well as 'edit all posts' and 'delete all posts'. It would solve the problem if you added these extra options.

P.S. This is an edit made by clicking the edit button at the bottom of my post. It will remain there until someone replies - then it will go.

davidteall’s picture

Sorry salvis. I've just discovered you have answered this here:
http://drupal.org/node/1503376
I will try the dev version.

salvis’s picture

Status: Active » Closed (fixed)