Allow editing own unreplied-to comments even without permission
lewmich - August 26, 2009 - 17:10
| Project: | Forum Access |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
Drupal has built-in permission for editing own comments until someone replied to that comment.
After installing Forum Access module, comments in a Forum cannot be edited by owners. Disabling Forum Access restores possibility to edit own comments.
I set following permissions:
- in Forum Access - "view" and "post" rights for authenticated users in /admin/content/forum/edit/forum/[num]
What is more, when enabling "edit posts" right in Forum Access - authenticated users gets permission to edit and delete ALL comments (sent by different users).
I did not find solution for this problem. Anyone can help?
#1
#2
As it says under Permissions information:
Also, Edit is 'edit', not 'edit own.'
Everything is working as designed and documented.
#3
1. In my case edit also gives rights to delete replies - which should depend on delete permission in Forum Access - this is a BUG in my opinion. Isn't it?
2. In my opinion, when users are not granted in Forum Access with edit permission (permission to edit all posts), they should still be able to edit their own replies - according to global, standard Drupal settings for comments. This functionality should not be shut down by Forum Access module. Is it a bug or functionality request?
Maybe there is something specific in my Drupal instalation that it works this unusual way... But I have not found anything...
I will appreciate your help!!
#4
Yes, #1 would be a bug — I'll look into it.
#2 is a feature request, but so far it hasn't found overwhelming support.
I'm at DrupalCon right now, give me some more time...
#5
Thanks for informing me it is a BUG. I went crazy trying to figure what was wrong with my site.
#6
Indeed, I find that the [Delete] button is visible, even though the user only has Edit rights. However, it doesn't actually work: I get an Access Denied message, when I click on it. IOW, this is a cosmetic issue, but it still needs to be fixed, of course.
#7
Thanks Salvis for your reply. I hope that it will be possible to fix this bug.
I will also really appreciate if it will be possible to let users edit their own comments. As I already said it is a standard, global drupal permission and in my opinion it should not be overridden by the Forum Access module.
Thanks for help!
m.
#8
Hello,
I also would appreciate to keep "edit own comment" permission working with forum access.
Regards,
Frederic
#9
Is the edit own comment permission not working?
I'm under the impression that the OP was referring to Drupal always allowing to edit your own comment as long as no one had replied to it, irrespective of the edit own comment permission. I haven't actually verified yet that Drupal (without FA) really does behave that way.
I've corrected the title, since this is not about a permission at all.
@flebas: if you really mean "permission", then please open a new thread.
#10
I've just committed a fix that removes the unusable [Delete] button (among other things). Give it up to 12h to be repackaged.
This removes the bug part of this issue. What remains is a feature request — I'm still working on clarifying the title...
(Having more than one issue in a single issue thread is a pain!)
#11
#597616: Edit link not displayed on own comments made me realize that it's a bug after all.
Committed to 6.x-1.x-dev — give it up to 12 hours to be repackaged, and let us know how it works.
#12
Automatically closed -- issue fixed for 2 weeks with no activity.