This bug affects the project module on Drupal.org.
When trying to create or edit a project you receive the following error upon submitting the form:
"You have to specify a valid CVS directory."
There is no field to specify a valid CVS directory.
Didn't have the chance to look and see if this field was taken out on purpose and the validation code left in unnecessarily, or if the field was accidentally deleted from the form or some other weirdness.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | cvslog-form_alter_0.patch | 1.72 KB | nedjo |
| #2 | cvslog-form_alter.patch | 2.88 KB | nedjo |
Comments
Comment #1
nedjoThis error is generated by the CVS module. It looks like the directory field is not registering properly.
Comment #2
nedjoThe fieldset that includes the cvs directory wasn't being added to the project editing form. Looks like we've dropped the 'form'
hook_nodeapi()op. Attached patch uses ahook_form_alter()instead, reinstating this fieldset.Comment #3
killes@www.drop.org commentedI've been testing it, but for some reason the cvs fields don't get preselected.
Comment #4
nedjoWe need to load the $node in a form_alter. Here's another try.
It seems an awkward way to have to alter node forms, though. Can anyone confirm that the 'form' op was removed from
hook_nodeapi()? Is a_form_alter()the expected replacement?Comment #5
killes@www.drop.org commentedWasn't there a $form[#node] thing? Adrian already committed your previous patch.
Comment #6
killes@www.drop.org commentedyep, that fixed it
Comment #7
(not verified) commented