A block is described as a box on the page. A box is actually also a custom block. After some talk on IRC, to get this more straight, we should rename box to block_custom. This patch does this. It also changes the block.info description to take into account that $content is now a block on its own.

CommentFileSizeAuthor
#9 box-to-custom-block-3.patch3.26 KBdavyvdb
#3 box-to-custom-block-2.patch21.88 KBdavyvdb
box-to-custom-block.patch21.4 KBdavyvdb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dries’s picture

Dries CreditAttribution: Dries commented
Issue tags: +Favorite-of-Dries

I think that would be a good clean-up. Haven't reviewed the patch yet.

Status: Needs review » Needs work

The last submitted patch failed testing.

davyvdb’s picture

davyvdb CreditAttribution: davyvdb commented
Status: Needs work » Needs review
FileSize
box-to-custom-block-2.patch21.88 KB
ksenzee’s picture

ksenzee
she/her
Location Seattle area
CreditAttribution: ksenzee commented
Status: Needs review » Reviewed & tested by the community

Installed this and banged around (I know, tests, I shouldn't have to, but still...) and it looks good. Read through the code and it looks good. ("Visual building blocks" is a good descriptor.) I think {block_custom} is a fine name. RTBC as far as I'm concerned.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs documentation

This is one of my favourite patches in D7. :) Committed to HEAD!

This needs to be documented in the module upgrade guide: http://drupal.org/update/modules/6/7

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

This upgrade path is going to fail because we are using the new table name in upgrades before system_update_7037(). Please don't change the table names before system_update_7037().

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Category: task » bug
Priority: Normal » Critical
eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
CreditAttribution: eojthebrave commented

I think this needs an update hook added to block.install to rename the box table to block_custom.

davyvdb’s picture

davyvdb CreditAttribution: davyvdb commented
Status: Needs work » Needs review
FileSize
box-to-custom-block-3.patch3.26 KB

This should fix this. Thanks for the catch Dave!

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

davyvdb’s picture

davyvdb CreditAttribution: davyvdb commented
Category: bug » task
Priority: Critical » Normal
Status: Fixed » Needs work

We still need documentation. http://drupal.org/node/561970#comment-1982240

hass’s picture

hass CreditAttribution: hass commented

+

yrocq’s picture

yrocq CreditAttribution: yrocq commented
Status: Needs work » Fixed
Issue tags: -Needs documentation

Documentation posted

#d7csmtl

Status: Fixed » Closed (fixed)
Issue tags: -Favorite-of-Dries

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Favorite-of-Dries

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.