Rename 'box' to the easier understandable 'custom block' (and {box} to {block_custom})... [#561970]

Comment	File	Size	Author
#9	box-to-custom-block-3.patch	3.26 KB	davyvdb
#3	box-to-custom-block-2.patch	21.88 KB	davyvdb
	box-to-custom-block.patch	21.4 KB	davyvdb

Comment #1

dries commented 28 August 2009 at 07:54

Issue tags:

+Favorite-of-Dries

I think that would be a good clean-up. Haven't reviewed the patch yet.

Log in or register to post comments

Comment #2

28 August 2009 at 08:01

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Log in or register to post comments

Status	File	Size
new	box-to-custom-block-2.patch	21.88 KB

Comment #4

ksenzee

she/her

commented 28 August 2009 at 18:10

Status:

Needs review

» Reviewed & tested by the community

Installed this and banged around (I know, tests, I shouldn't have to, but still...) and it looks good. Read through the code and it looks good. ("Visual building blocks" is a good descriptor.) I think {block_custom} is a fine name. RTBC as far as I'm concerned.

Log in or register to post comments

Comment #5

webchick

she/they

English

Vancouver 🇨🇦

commented 28 August 2009 at 19:44

Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Needs documentation

This is one of my favourite patches in D7. :) Committed to HEAD!

This needs to be documented in the module upgrade guide: http://drupal.org/update/modules/6/7

Log in or register to post comments

Comment #6

dave reid

he/him

English

Nebraska USA

commented 28 August 2009 at 20:50

This upgrade path is going to fail because we are using the new table name in upgrades before system_update_7037(). Please don't change the table names before system_update_7037().