After applying the patch from #490434: Watchdog calls causes syslog errors in jq, the errors are logged correctly and I get The cycle jQuery plugin is not defined

However everything works correctly except this error !

CommentFileSizeAuthor
#5 views_slideshow-562196-5.patch1.36 KBguillaumeduveau
#4 jq-562196-1.patch2.48 KBredndahead
#2 views_slideshow-562196-2.patch930 bytesguillaumeduveau
#1 views_slideshow-562196-1.patch925 bytesguillaumeduveau

Comments

guillaumeduveau’s picture

guillaumeduveau
Location Toulouse
commented
Version: 6.x-1.0-beta2 » 6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new views_slideshow-562196-1.patch925 bytes

We can have the jq module installed, without having the jquery cycle plugin. Here's the patch.

guillaumeduveau’s picture

guillaumeduveau
Location Toulouse
commented
StatusFileSize
new views_slideshow-562196-2.patch930 bytes

Oups that was causing a Fatal PHP error, here's a new patch.

redndahead’s picture

redndahead commented
Version: 6.x-1.x-dev » 6.x-2.x-dev

Good catch moving this to 2.x and may be able to use yours for the back port to 1.x. I don't use 1.x much, but maybe someone will go ahead and patch it.

redndahead’s picture

redndahead commented
Version: 6.x-2.x-dev » 6.x-1.x-dev
StatusFileSize
new jq-562196-1.patch2.48 KB

Will commit this patch for 2.x which includes hoverIntent. Don't know if hoverIntent is used in 1.x so it will need to be looked at before being committed.

guillaumeduveau’s picture

guillaumeduveau
Location Toulouse
commented
StatusFileSize
new views_slideshow-562196-5.patch1.36 KB

Yes it's also in 1.x, here's the patch.

redndahead’s picture

redndahead commented
Status: Needs review » Fixed

I'm going to close this. If one of the other devs wants to work on 1.x they can feel free to commit. I'm planning on only focusing on 2.x. Otherwise we can leave the patch here and someone can use it if needed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.