Download & Extend

Error : the cycle jQuery plugin is not defined

Project:Views Slideshow
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

After applying the patch from #490434: Watchdog calls causes syslog errors in jq, the errors are logged correctly and I get The cycle jQuery plugin is not defined

However everything works correctly except this error !

Comments

#1

Version:6.x-1.0-beta2» 6.x-1.x-dev
Status:active» needs review

We can have the jq module installed, without having the jquery cycle plugin. Here's the patch.

AttachmentSize
views_slideshow-562196-1.patch 925 bytes

#2

Oups that was causing a Fatal PHP error, here's a new patch.

AttachmentSize
views_slideshow-562196-2.patch 930 bytes

#3

Version:6.x-1.x-dev» 6.x-2.x-dev

Good catch moving this to 2.x and may be able to use yours for the back port to 1.x. I don't use 1.x much, but maybe someone will go ahead and patch it.

#4

Version:6.x-2.x-dev» 6.x-1.x-dev

Will commit this patch for 2.x which includes hoverIntent. Don't know if hoverIntent is used in 1.x so it will need to be looked at before being committed.

AttachmentSize
jq-562196-1.patch 2.48 KB

#5

Yes it's also in 1.x, here's the patch.

AttachmentSize
views_slideshow-562196-5.patch 1.36 KB

#6

Status:needs review» fixed

I'm going to close this. If one of the other devs wants to work on 1.x they can feel free to commit. I'm planning on only focusing on 2.x. Otherwise we can leave the patch here and someone can use it if needed.

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here