Show unclassified group description even when group title is blank
jonathan1055 - August 30, 2009 - 10:03
| Project: | Web Links |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
Currently if the Unclassified group title is blank then the descriptive text is not shown. I think this limitation can be lifted because if the admin does not want text they can remove it via the admin group settings. However, there could well be cases when we want descriptive text but no title. So in _weblinks_unclassed() I suggest we remove the condition of $noclass->name having a value:
<?php
$noclass->description = $noclass->name ? variable_get('weblinks_unclassified_desc', t('These links have not been assigned a group.')) : '';
?>simply becomes:
<?php
$noclass->description = variable_get('weblinks_unclassified_desc', t('These links have not been assigned a group.'));
?>There is a similar condition in _weblinks_unpublished() which should also be removed, in fact here it is redundant anyway, because the
unpublished title can never be blank now, due to improvements made to the admin settings screen. The attached patch was rolled against dev 08-29
Jonathan
| Attachment | Size |
|---|---|
| _weblinks.empty_name.patch.txt | 1.12 KB |
#1
I agree.
#2
#3