Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Url's are mangled and the usage of the private download method has changed since today.. (Dopry, You are the man for me!)..
More info to come..
Comment | File | Size | Author |
---|---|---|---|
#6 | image-module-fix-image-display.diff | 1.55 KB | Stefan Nagtegaal |
#4 | image-private.patch | 1.54 KB | decafdennis |
Comments
Comment #1
decafdennis CreditAttribution: decafdennis commentedMarked http://drupal.org/node/56364 as a duplicate of this issue.
Comment #2
decafdennis CreditAttribution: decafdennis commented...http://drupal.org/node/56794 that is.
Comment #3
decafdennis CreditAttribution: decafdennis commentedI discussed a bit with dopry, and I'll look into it to see what's the best way to solve this problem.
Comment #4
decafdennis CreditAttribution: decafdennis commentedThe
theme_image
function is used by a few modules (e.g. forum) to renderimg
tags for images that are directly accessible for the webclient (e.g. misc/forum-new.png). It does not work for private downloads, because it does not support full URLs (it corrupts them by appendingbase_path()
).That's why I think the best solution to this problem is to give the image module a theme function of its own:
theme_image_display
. My patch does just that.Comment #5
decafdennis CreditAttribution: decafdennis commentedComment #6
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedCode works for both private and public downloads. Tested on several servers.
I rerolled the patch so applies cleanly and setting status to RTBC..
This brings image.module back to bussiness. Good work naquah!
Comment #7
decafdennis CreditAttribution: decafdennis commentedThanks!
Comment #8
walkah CreditAttribution: walkah commentedcommitted. thanks guys.
Comment #9
(not verified) CreditAttribution: commented