Url's are mangled and the usage of the private download method has changed since today.. (Dopry, You are the man for me!)..

More info to come..

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

decafdennis’s picture

Marked http://drupal.org/node/56364 as a duplicate of this issue.

decafdennis’s picture

decafdennis’s picture

Assigned: Unassigned » decafdennis

I discussed a bit with dopry, and I'll look into it to see what's the best way to solve this problem.

decafdennis’s picture

FileSize
1.54 KB

The theme_image function is used by a few modules (e.g. forum) to render img tags for images that are directly accessible for the webclient (e.g. misc/forum-new.png). It does not work for private downloads, because it does not support full URLs (it corrupts them by appending base_path()).

That's why I think the best solution to this problem is to give the image module a theme function of its own: theme_image_display. My patch does just that.

decafdennis’s picture

Status: Active » Needs review
Stefan Nagtegaal’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
1.55 KB

Code works for both private and public downloads. Tested on several servers.

I rerolled the patch so applies cleanly and setting status to RTBC..
This brings image.module back to bussiness. Good work naquah!

decafdennis’s picture

Thanks!

walkah’s picture

Status: Reviewed & tested by the community » Fixed

committed. thanks guys.

Anonymous’s picture

Status: Fixed » Closed (fixed)