Url's are mangled and the usage of the private download method has changed since today.. (Dopry, You are the man for me!)..

More info to come..

CommentFileSizeAuthor
#6 image-module-fix-image-display.diff1.55 KBStefan Nagtegaal
#4 image-private.patch1.54 KBdecafdennis

Comments

decafdennis’s picture

decafdennis commented

Marked http://drupal.org/node/56364 as a duplicate of this issue.

decafdennis’s picture

decafdennis commented

...http://drupal.org/node/56794 that is.

decafdennis’s picture

decafdennis commented
Assigned: Unassigned » decafdennis

I discussed a bit with dopry, and I'll look into it to see what's the best way to solve this problem.

decafdennis’s picture

decafdennis commented
StatusFileSize
new image-private.patch1.54 KB

The theme_image function is used by a few modules (e.g. forum) to render img tags for images that are directly accessible for the webclient (e.g. misc/forum-new.png). It does not work for private downloads, because it does not support full URLs (it corrupts them by appending base_path()).

That's why I think the best solution to this problem is to give the image module a theme function of its own: theme_image_display. My patch does just that.

decafdennis’s picture

decafdennis commented
Status: Active » Needs review
Stefan Nagtegaal’s picture

Stefan Nagtegaal commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new image-module-fix-image-display.diff1.55 KB

Code works for both private and public downloads. Tested on several servers.

I rerolled the patch so applies cleanly and setting status to RTBC..
This brings image.module back to bussiness. Good work naquah!

decafdennis’s picture

decafdennis commented

Thanks!

walkah’s picture

walkah commented
Status: Reviewed & tested by the community » Fixed

committed. thanks guys.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)