The watchdog call for "There are @count links in error and the maximum number being checked per run is !limit." is incorrectly formed and results in errors when the log is viewed.

Comments

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Assigned: Unassigned » nancydru
Status: Active » Fixed

Committed.

jonathan1055’s picture

jonathan1055 commented

It is working for me fine, and the watchdog db table looks OK.
Could you let me know what was wrong, so that I don't make the same error again?

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I had my limit set to 2, and when I saw your new issues, changed the setting to look at links in error first. That's when that message started coming out. The mistake was very easy to make; the substitution value array needed to come outside the format_plural.

jonathan1055’s picture

jonathan1055 commented

OK I can see what you have changed, but the old version was working (at least for me) and I do not get any errors when viewing the log. So is the change just an improvement for standards and for help with translations? Of course I am fine with the change, but I just need to understand why I am not getting the error you mentioned when viewing the log, so I don't post other code which needs fixing by you. I don't want you to think I had not tested it!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

No, the recent logs report actually showed an error (IIRC, "Invalid foreach...") and the message field was blank. It only happened when that particular message came out, which probably most people won't ever see.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Fixed » Closed (fixed)