In fresh install block "revisions pendng" didn't shown on pages. All permissions set to enabled.
But in page accessible-content/i-last-modified/pending I see all pending revisions.
The problem is that none of material types have this option enabled at page admin/content/node-type/page (enabled by default in edit form):
- New revision in draft, pending moderation (requires "Create new revision")
If I enable this option, the block show normally.
But I didn't want to have this option by default, I want to set it manually.
I think the block must not look to this variable for showing the content.
The problem is near the code of function revisioning_block() in file revisioning.module on this strings:
<? $nodes = get_nodes('update', NO_FILTER, NO_FILTER, NO_FILTER, TRUE, TRUE, 100, FALSE, 'timestamp '. $order); ?>
It returns empty list if this option isn't set.

Comments

murz’s picture

murz
Primary language English
Location Yerevan, Armenia
commented

Sorry I tell about function get_nodes() in post before.

Maybe the bug is in "module_grants" module because it have in function get_nodes() the string:
<? $filter = ($is_moderated < 0) || $is_moderated == is_moderated($node->type); ?>
This string is look at that variable and return false if it isn't set.

rdeboer’s picture

rdeboer
Location Melbourne
commented

Thanks for your interesting in Revisioning Murz!

The "Revisions pending" block is first and foremost for moderators, and by design only returns moderated content, i.e. content of a type has the "New revision in draft, pending moderation" box ticked.

The accessible-content/i-can-view/pending tab is a more generic content monitor. When logged in with a role that has "administer nodes" permission the tab will display any "pending" revisions, even if these are of a content type for which "New revision in draft, pending moderation" is NOT set (e.g. a content type that used to be moderated but no longer is). This is so that when logged in as an administrator you get to see all content, and no revisions get overlooked.

Rik

murz’s picture

murz
Primary language English
Location Yerevan, Armenia
commented

I look ant can't see the "Revisions pending" block as moderator and as administrator! It must shows the content of a type has the "New revision in draft, pending moderation" box ticked, but if this ticket for any content type didn't marked as default (in content-type settings), but site have some nodes with "New revision in draft, pending moderation" box ticked manually in node edit form, they isn't shows in a block, and all the block didn't shows too. If I turn on the box "New revision in draft, pending moderation" in "Default settings for node type" of content settings (admin/content/node-type/page), it shows normally.

rdeboer’s picture

rdeboer
Location Melbourne
commented

Oh you mean you have content of a type for which "New revision in draft, pending moderation" isn't set on the admin/content/node-type/page, but than you have overridden that on the Edit form of some individual nodes.
Yes that might be a bug. However, it will only be an issue for roles that are allowed to override the "New revision in draft, pending moderation" setting for the content type on the Edit form form for the individual node. Typically it would only be the administrator who can create such an exceptional situation.

murz’s picture

murz
Primary language English
Location Yerevan, Armenia
commented

Yes, you have correctly understood me. But this bug shows not only for administrators, I have the site in which I must send not all content to moderation, but only some nodes. And in this case the moderator didn't see this nodes in block.

rdeboer’s picture

rdeboer
Location Melbourne
commented
Status: Active » Closed (fixed)

Can't reproduce.