i still get lots of these when saving a file:
implode(): Bad arguments. in /var/**/modules/audio/getid3/getid3/write.php on line 475.

... saw on the getid3 page that it's probably a getid3 bug.
the errors still appear with the "show getid3 errors" unchecked.
i think the error only appeared after upgrading from drupal 4.6 to 4.7b6.

CommentFileSizeAuthor
#13 audio.module_hook_2.patch8.6 KBdrewish
#12 audio.module_56589_0.patch705 bytesdrewish
#8 audio_write_commentadd.patch661 bytesasimmonds
#1 audio.module_56589.patch1.39 KBdrewish

Comments

drewish’s picture

drewish commented
Status: Active » Fixed
StatusFileSize
new audio.module_56589.patch1.39 KB

I've committed a fix for this that leoburd suggested in another thread. I'm not sure if it's a complete fix so if you continue to encounter the bug please re-open the issue.

ju.ri’s picture

ju.ri commented
Status: Fixed » Active

thanks!
but.. error still shows up
which getid3 version do you work with now? is 1.76 recommended? the install.txt is a little unclear with that.

leoburd’s picture

leoburd commented

Please test the new patch that I've just submitted on http://drupal.org/node/57467 . I believe it will fix the problem you're facing...

.L.

drewish’s picture

drewish commented

yeah, that's a bug with the getID3 library. per the INSTALL.TXT file:

a. Download the project getId3 version from SourceForge.net. The latest
version tested with the audio module is 1.7.5.
UPDATE: Several bugs that affect the audio module have been fixed since
the last public release. Until 1.7.6 is released, use this development
version: http://drupal.org/files/issues/getid3.zip

i'm not too inclined to apply leoburd's fix because it's really a bug in getID3 and i'd rather have them fix that.

leoburd’s picture

leoburd commented

please note that the bug fixed with my patch persists even with the getId3 library recommended in the INSTALL.TXT file...

drewish’s picture

drewish commented

oh, now i'm seeing your confusion. they've finally released 1.7.6 ;)

drewish’s picture

drewish commented

leoburd, here's the getID3 bug report i opened way back when: http://www.getid3.org/phpBB2/viewtopic.php?t=473

asimmonds’s picture

asimmonds commented
StatusFileSize
new audio_write_commentadd.patch661 bytes

With the current audio.module, the warning only displays for me, if the Error handling > Error reporting in admin/settings is set to "Write errors to the log and to the screen" as Drupal's own error_handler() is catching this message.

Adding the comment tag portion from the patch in http://drupal.org/node/57467 to audio.module removed the warning completely for my uploads (patch attached).

drewish’s picture

drewish commented

see also: http://drupal.org/node/56589

drewish’s picture

drewish commented

woops, got that backwards, see: http://drupal.org/node/62957

drewish’s picture

drewish commented

see also: http://drupal.org/node/63597

as much as i'd rather see getid3 fixed, it looks like we might need to apply something like leoburd or asimmonds's patch.

drewish’s picture

drewish commented
Title: write.php errors when tag info is empty » write.php errors when tag info is empty
Status: Active » Reviewed & tested by the community
StatusFileSize
new audio.module_56589_0.patch705 bytes

anyone see a problem with this patch?

drewish’s picture

drewish commented
StatusFileSize
new audio.module_hook_2.patch8.6 KB

this is a slightly better patch. it adds calls for download and play so that other modules could do statistics tracking, like this: http://drupal.org/node/63765.

drewish’s picture

drewish commented

crap ignore that last patch. posted to the wrong issue.

drewish’s picture

drewish commented
Status: Reviewed & tested by the community » Fixed

i've committed #12

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)