If the contact form only has a single category, it spits out a nasty error when you go to http://yourwebsite/contact/

Fatal error: Only variables can be passed by reference in /home/www/dev/modules/contact.module on line 467

Line 467 is '#value' => array_shift(array_keys($categories)),

array_shift takes its parameter by ref

Hacker fix: Adding a second category (although unnecessary) causes the error to no longer occur. Not a real solution.

CommentFileSizeAuthor
#3 contact.module.patch_1.txt669 bytesdrewish
#2 contact.module.patch_0.txt677 bytesdrewish

Comments

chx’s picture

chx commented
Priority: Critical » Minor

since when this is critical?

drewish’s picture

drewish commented
Status: Active » Needs review
StatusFileSize
new contact.module.patch_0.txt677 bytes

here's a simple patch

drewish’s picture

drewish commented
StatusFileSize
new contact.module.patch_1.txt669 bytes

actually, that variale name sucked.

drewish’s picture

drewish commented

see also http://drupal.org/node/57517

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Fixed

a similar patch already got applied.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)