Hello Folks,

Please look into this issue, $db_prefix if set in settings.php is respected when module installs, but when a new cases are being created then it fails with lot of warnigs that requested tables doesn't exist.

T.

CommentFileSizeAuthor
#1 casetracker_001.patch3.18 KBtomsys

Comments

tomsys’s picture

tomsys commented
Status: Active » Needs review
StatusFileSize
new casetracker_001.patch3.18 KB

Here is initial patch .. please look into that may be you want to make it more accurate.

T.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Needs work

you're basically on the right track. however, please don't leave the old lines commented out in the patch. thanks.

tomsys’s picture

tomsys commented

Hi,

Thank you for your reply on today. It works for me and before someone who is on dev team will change an actual module I thought that they will be happy to see what was changed .. and there were bunch of comment's in that module anyway.. so I used the same pattern.

Feel free to do further upgrades.. I'm providing that patch just to share what I changed and may be it will help dev team to commit bugfixe's faster .. this patch really need's some expert review .. it was done on hurry..

T.

Tobias Maier’s picture

Tobias Maier commented

it woud be really nice if you could change your patch so the core developers don only need to apply your patch and dont need to chage anything...

if you take a look at the patch file you can see that it is really easy to guess what was changed...

-   $result = db_query('DESCRIBE %s', $form_values['casetracker_table_name']);
+   // $result = db_query('DESCRIBE %s', $form_values['casetracker_table_name']);
+   $result = db_query('DESCRIBE {%s}', $form_values['casetracker_table_name']);

so everyone can review your patch without the need of the commented out code

killes@www.drop.org’s picture

killes@www.drop.org commented

Tobias: the ongoing development of casetracker.module is paid for and thus such things don't really matter. :p

sanjeev gupta’s picture

sanjeev gupta commented
Status: Needs work » Fixed

The patch has been applied.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)